Quick-search filter bar background appearance is hard coded, may not work well with desktop theme

RESOLVED FIXED in Thunderbird 3.3a1

Status

Thunderbird
Search
--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: rsx11m, Assigned: rsx11m)

Tracking

Trunk
Thunderbird 3.3a1
x86
Windows XP
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird3.1 rc1-fixed)

Details

Attachments

(5 attachments)

(Assignee)

Description

8 years ago
All toolbars adhere to the background scheme of the selected desktop theme, except for the just introduced quick-search/filter bar (qfb). It comes with a hard-coded background as specified in quickFilterBar.css (a blueish gradient
for #quick-filter-bar-main-bar, and a constant background color for the expanded #quick-filter-bar-expando).

Even if this was intentional, it draws an unusual focus on the qfb even if it's not active. I'll post a screenshot using the Windows Classic desktop theme in a minute, but I can imagine that colors of other desktop themes may not go well with that choice (which was possibly made based on the Win7 appearance?).

I've also noticed that the message list changes colors to indicate the current status of the search, i.e., turning similarly blue whenever search results are currently displayed. Proposal: Show the the qfb background color only if it's currently active, but leave it "background: none" in an inactive state (i.e., when showing the "Ctrl+F" default text). This may be a good compromise, under the assumption that the background colors were selected on purpose. The other option would be to derive the background color from the desktop's background color somehow, but even then I would show the default if the qfb is not active.
(Assignee)

Comment 1

8 years ago
Created attachment 443949 [details]
Comparison of background appearances

The top sreenshot shows the qfb appearance as currently implemented, in an inactive state. The bottom version shows it on a neutral background.

This was done with the Windows Classic theme on Windows XP.
We can probably work around this if we add the following rule, :-moz-system-metric(windows-default-theme) to our background color choice; it might need to be split out.  This will only set it when using the windows default theme.

rsx11m: do you think you could make a patch that does this?
(Assignee)

Comment 3

8 years ago
I'm still too tied up to take this myself, thus whoever wants to work on it, please go ahead...
(Assignee)

Comment 4

8 years ago
Created attachment 444558 [details] [diff] [review]
Proposed patch

Given that there are just a few days left until the RC1 freeze, I've squeezed in a patch implementing Bryan's suggestion in comment #2. This retains the original background and border design of bug 545955 for the default theme. For any other theme, it uses the definitions for regular toolbars and separators based on toolkit's toolbar.css. Note that the message list itself still switches colors, this is a nice feedback to the user that the quick-search filter is active.
Attachment #444558 - Flags: ui-review?(clarkbw)
(Assignee)

Comment 5

8 years ago
Created attachment 444559 [details]
Appearance using Windows XP default theme

This shows the quick-filter bar before (top) and after (bottom) applying the patch. There is no change in appearance, I’m posting this in case someone wants to double-check.
(Assignee)

Comment 6

8 years ago
Created attachment 444560 [details]
Appearance using Windows Classic theme

Here a non-default theme, now the quick-filter bar shows the same background and border appearance (including 1px border sizes) like all other toolbar components, thus leaving it up to the desktop theme to define the color scheme. Also, the "Quick Filter:" label is shown in regular label color to avoid gray-on-gray appearance.

I've tested this on Windows XP based on the comm-1.9.2 branch (don't have any Vista or Windows 7 around).
Comment on attachment 444558 [details] [diff] [review]
Proposed patch

Wow, that was fast!  I haven't had a chance to test this out, tomorrow morning I'll try to build Windows but it looks pretty good code-wise and from the screenshots.  Where pretty good is a ring above how we generally look on XP :(
Attachment #444558 - Flags: ui-review?(clarkbw) → ui-review+
(Assignee)

Updated

8 years ago
Attachment #444558 - Flags: review?(bugzilla)
Attachment #444558 - Flags: review?(bugzilla) → review?(nisses.mail)
The only thing I could find in my review was some trailing spaces on line 71 in quickFilterBar.css, but that didn't seem to originate from your patch. Will give the patch a quick run in action before I give r+, but the code looks all well as far as I can see.
Comment on attachment 444558 [details] [diff] [review]
Proposed patch

Tried it in action too and it looks good to me!
Attachment #444558 - Flags: review?(nisses.mail) → review+
(Assignee)

Comment 10

8 years ago
Created attachment 444885 [details] [diff] [review]
Patch for check-in

White-space changes only relative to attachment 444558 [details] [diff] [review].
Minimal risk for 1.9.2 branch, just theme adjustments.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #444885 - Flags: approval-thunderbird3.1?
(Assignee)

Comment 11

8 years ago
I'm not sure whether or not this has to land and bake on trunk first before getting branch approval, also given the RC1 freeze deadline. If yes, please
push to comm-central only with an estimated baking time; otherwise, push to
both comm-central and comm-1.9.2, pending branch approval.
Keywords: checkin-needed
Checked in on trunk:
http://hg.mozilla.org/comm-central/rev/d1fa43776d9d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
Attachment #444885 - Flags: approval-thunderbird3.1? → approval-thunderbird3.1+
Checked in to 1.9.2:
http://hg.mozilla.org/releases/comm-1.9.2/rev/1e5125a548b8
status-thunderbird3.1: --- → rc1-fixed
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.