564299 - Multiple select can have scrollbars

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, the first multiple select has scrollbars (weird scrollbars), the second not. I guess the first one shouldn't show up scrollbars at all.

My guess is that the patch from bug 500208 has something to do with it.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Very strange. Just adding a "size" attribute to the <select> fixes the problem:

<select multiple style="100px" size> ...

Must be something with the CSS in content.css

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Found it. We assumed that the presence of the "size" attribute was the only thing that controlled whether a <select> was a listbox or a dropdown. However, the "multiple" attribute will force the <select> into a listbox mode even if the "size" attribute is omitted.

Patch coming up.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Anytime we do a :not([size]) we also need to do a :not([multiple])

That's what this patch does. Please test it out and make sure I didn't break focus highlight or any other CSS states. It fixes this testcase and seems to work ok on:
http://people.mozilla.org/~mfinkle/select.html
and:
http://www.vingtetun.org/tmp/forms.html

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 444023 [details] [diff] [review]
patch

Code looks ok.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-b:
http://hg.mozilla.org/mobile-browser/rev/73c274b96744

pushed m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/a14f3f5a859a

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100511 Namoroka/3.6.5pre Fennec/1.1b2pre

and

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a5pre) Gecko/20100511 Namoroka/3.7a5pre Fennec/2.0a1pre

Comment 7

[Aakash Desai [:aakashd]]

minus'ing the litmus testcase nomination as this works a lot better as a unit test.