564530 - Change Redirect for zh-CN locale of Firefox Uninstall Survey

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[ken kovash]

For the Firefox Uninstall Survey, we need to modify the redirect rules so that the Chinese locale goes to a different landing page.  The current implementation and redirect rules are discussed in bugs 489696 and 496023.

More specifically, the zh-CN locale of the uninstall survey should direct users to http://www.g-fox.cn/chn_feedback/uninstall.html.  The redirect behavior for all other locales should remain as-is.

Comment 1

[Alex Buchanan [:abuchanan]]

So,

http://www.mozilla.com/zh-CN/firefox/uninstall/

needs to redirect to

http://www.g-fox.cn/chn_feedback/uninstall.html

right?

Comment 2

[ken kovash]

(In reply to comment #1)
> So,
> 
> http://www.mozilla.com/zh-CN/firefox/uninstall/
> 
> needs to redirect to
> 
> http://www.g-fox.cn/chn_feedback/uninstall.html
> 
> right?

yes, I believe that's correct.

Comment 3

[Alex Buchanan [:abuchanan]]

r67139 on trunk

http://www-trunk.stage.mozilla.com/zh-CN/firefox/uninstall/

Comment 4

[Alex Buchanan [:abuchanan]]

r67141 on stage and production

Comment 5

[ken kovash]

Amax -- can you confirm that you're receiving data (i.e., survey responses)?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

http://www-trunk.stage.mozilla.com/zh-CN/firefox/uninstall/

GET /zh-CN/firefox/uninstall/ HTTP/1.1
<snip>

HTTP/1.1 302 Found
Date: Thu, 13 May 2010 00:06:16 GMT
Server: Apache
X-Powered-By: PHP/5.1.6
Location: http://www.g-fox.cn/chn_feedback/uninstall.html
Cache-Control: max-age=900, private, private
Expires: Thu, 13 May 2010 00:21:16 GMT
X-Backend-Server: dm-cms03
Content-Length: 0
Keep-Alive: timeout=15, max=100
Connection: Keep-Alive
Content-Type: text/html; charset=UTF-8
----------------------------------------------------------
http://www.g-fox.cn/chn_feedback/js/util.htm

The above is a 404.

Comment 7

[Lingfeng.Guan]

(In reply to comment #5)
> Amax -- can you confirm that you're receiving data (i.e., survey responses)?

Yes, we are receiving data, Thank you very much:)

Comment 8

[Lingfeng.Guan]

That seems to be a bug, and it's fixed already, thanks to you:)

(In reply to comment #6)
> http://www-trunk.stage.mozilla.com/zh-CN/firefox/uninstall/
> 
> GET /zh-CN/firefox/uninstall/ HTTP/1.1
> <snip>
> 
> HTTP/1.1 302 Found
> Date: Thu, 13 May 2010 00:06:16 GMT
> Server: Apache
> X-Powered-By: PHP/5.1.6
> Location: http://www.g-fox.cn/chn_feedback/uninstall.html
> Cache-Control: max-age=900, private, private
> Expires: Thu, 13 May 2010 00:21:16 GMT
> X-Backend-Server: dm-cms03
> Content-Length: 0
> Keep-Alive: timeout=15, max=100
> Connection: Keep-Alive
> Content-Type: text/html; charset=UTF-8
> ----------------------------------------------------------
> http://www.g-fox.cn/chn_feedback/js/util.htm
> 
> The above is a 404.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

LingFeng: that util.htm URL still 404s for me:

http://www.g-fox.cn/chn_feedback/js/util.htm



GET /chn_feedback/js/util.htm HTTP/1.1

Host: www.g-fox.cn


<snip>

HTTP/1.1 404 Not Found

Server: nginx/0.6.39

Date: Fri, 14 May 2010 03:33:49 GMT

Content-Type: text/html

Comment 10

[Lingfeng.Guan]

Stephend: Yes, you're right. That page does not exist. This is a bug, that script tag with src="js/util.html" shouldn't be in the uninstall survey page. The developer forgot to delete that line before publish, and it's fixed, thx to you:)

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Ah, ok; thanks for clearing that up.  Verified FIXED.

Comment 12

[Lingfeng.Guan]

You're welcome, and thank you very much for everything:)

Comment 13

[ken kovash]

Not sure what's wrong, but Amax from the China office just emailed with these details:

"We found that when we uninstall Firefox3.6.3, the survey page is now going to https://survey.mozilla.com/1/Mozilla%20Firefox/3.6.3/zh-CN/exit.html, and then redirected to http://www.mozilla.com/en-US/firefox/uninstall/?version=1&application=Mozilla%20Firefox&ua=3.6.3&lang=zh-CN but not http://www.mozilla.com/zh-CN/firefox/uninstall/. So our localized uninstall survey page is not triggered. Could you help us on this?"

Comment 14

[Lingfeng.Guan]

Thanks, Ken and sorry for the late response.

It seems that we were redirecting the wrong url. What we did is redirect http://www.mozilla.com/zh-CN/firefox/uninstall/ to http://www.g-fox.cn/chn_feedback/uninstall.html

But I found in the Firefox code that the uninstall survey url is actually
https://survey.mozilla.com/1/Mozilla%20Firefox/${AppVersion}/${AB_CD}/exit.html
(defined in http://mxr.mozilla.org/mozilla-central/source/other-licenses/branding/firefox/branding.nsi#47)
and in our case that is https://survey.mozilla.com/1/Mozilla%20Firefox/3.6.6/zh-CN/exit.html
and this page is redirected to http://www.mozilla.com/en-US/firefox/uninstall/?version=1&application=Mozilla%20Firefox&ua=3.6.3&lang=zh-CN 
instead of http://www.mozilla.com/zh-CN/firefox/uninstall/.

So maybe we should redirect https://survey.mozilla.com/1/Mozilla%20Firefox/${AppVersion}/zh-CN/exit.html to http://www.mozilla.com/zh-CN/firefox/uninstall/?version=1&application=Mozilla%20Firefox&ua=3.6.3 instead of http://www.mozilla.com/en-US/firefox/uninstall/?version=1&application=Mozilla%20Firefox&ua=3.6.3&lang=zh-CN ?

Comment 15

[Alex Buchanan [:abuchanan]]

Attachment: patch for survey.m.c, redirects to proper locale on moz.com

Wenzel, do you know how survey.m.c updates?  Is it automatic?  Manual via IT?

Comment 16

[Alex Buchanan [:abuchanan]]

Attachment: patch redirect on mozilla.com, so it includes query string

Comment 17

[Fred Wenzel [:wenzel]]

Comment on attachment 457432 [details] [diff] [review]
patch redirect on mozilla.com, so it includes query string

Do we need [QSA] there or does this work even so?

Either way, your solution is quite a bit cleaner than the previous one.

Comment 18

[Alex Buchanan [:abuchanan]]

No need for QSA, I tested that.  (I think because it's Redirect, not RewriteRule)

Comment 19

[Fred Wenzel [:wenzel]]

(In reply to comment #15)
> Wenzel, do you know how survey.m.c updates?  Is it automatic?  Manual via IT?

Not the slightest idea, given that I never got and answer over in bug 489696, it might have been automatic. If you have time, wait a little, if not, file an IT bug :)

Comment 20

[Lingfeng.Guan]

Guys, thank you so much