sync dialogs should persist size/position

VERIFIED FIXED in mozilla7

Status

Cloud Services
Firefox Sync: UI
--
minor
VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: tchung, Assigned: philikon)

Tracking

({polish})

unspecified
mozilla7
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [verified in services])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
When firefox is moved into a secondary shared monitor space, opening and closing modal dialogs should persist in the same coordinates after reopening.   This isnt true with the Weave setup modal dialog.

Repro:
1) install weave 1.3b5
2) move firefox to a secondary shared monitor
3) fire up prefpane or any other modal dialog (addons manager). then close it
4) reopen, and notice the prefpane or other firefox modal dialog retains it coordinates
5) now do the same action, but this time open prefpane, then sync, and the sync setup dialog page
6) close it all, and reopen
7) Verify sync setup page always defaults back to the same coordinates in the main screen, while everything else is in the secondary monitor screen.

Expected:
- sync setup modal dialog persists its location after closing and reopening

Actual:
- sync setup modal dialog shifts back to main desktop space and its default coordinates.
(Reporter)

Updated

8 years ago
Severity: normal → minor
Whiteboard: [weave1.3]
needs some persist love for the wizard, not blocking 1.3 though.
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → 2.0
Need to add this to the window/wizard/dialog declarations:

persist="screenX screenY width height"

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/syncQuota.xul#51
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/syncSetup.xul#55

Minor polish fix, but also super trivial.
Keywords: polish
Summary: Sync setup modal dialog does not persist in secondary monitor → sync dialogs should persist size/position
Target Milestone: 2.0 → mozilla7
(In reply to comment #2)
> persist="screenX screenY width height"

Dialogs aren't resizable, so screenX/Y should be enough.
Created attachment 536140 [details] [diff] [review]
v1

The Sync setup/Sync Key/Add Device wizards are fixed size so just persisting screenX/Y for those. Quota is resizable, so persist width and height there.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #536140 - Flags: review?(rnewman)
(Assignee)

Updated

7 years ago
Whiteboard: [weave1.3]
Comment on attachment 536140 [details] [diff] [review]
v1

Review of attachment 536140 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #536140 - Flags: review?(rnewman) → review+
STRs for QA:

1. Open any of the Sync dialogs (setup wizard, My Sync Key, Change Password, View Quota, etc.)
2. Move them around and change size (latter only possible for View Quota)
3. Close and reopen the dialog. Position and size should have been restored.

Updated

7 years ago
Whiteboard: [fixed in services] → [verified in services]
http://hg.mozilla.org/mozilla-central/rev/443d2b2edbb3
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
verified in m-c build from 20110602
Status: RESOLVED → VERIFIED
No longer blocks: 687316
You need to log in before you can comment on or make changes to this bug.