Closed
Bug 564560
Opened 15 years ago
Closed 14 years ago
sync dialogs should persist size/position
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
mozilla7
People
(Reporter: tchung, Assigned: philikon)
References
Details
(Keywords: polish, Whiteboard: [verified in services])
Attachments
(1 file)
3.57 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
When firefox is moved into a secondary shared monitor space, opening and closing modal dialogs should persist in the same coordinates after reopening. This isnt true with the Weave setup modal dialog.
Repro:
1) install weave 1.3b5
2) move firefox to a secondary shared monitor
3) fire up prefpane or any other modal dialog (addons manager). then close it
4) reopen, and notice the prefpane or other firefox modal dialog retains it coordinates
5) now do the same action, but this time open prefpane, then sync, and the sync setup dialog page
6) close it all, and reopen
7) Verify sync setup page always defaults back to the same coordinates in the main screen, while everything else is in the secondary monitor screen.
Expected:
- sync setup modal dialog persists its location after closing and reopening
Actual:
- sync setup modal dialog shifts back to main desktop space and its default coordinates.
Reporter | ||
Updated•15 years ago
|
Severity: normal → minor
Whiteboard: [weave1.3]
Comment 1•15 years ago
|
||
needs some persist love for the wizard, not blocking 1.3 though.
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → 2.0
Comment 2•14 years ago
|
||
Need to add this to the window/wizard/dialog declarations:
persist="screenX screenY width height"
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/syncQuota.xul#51
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/syncSetup.xul#55
Minor polish fix, but also super trivial.
Keywords: polish
Summary: Sync setup modal dialog does not persist in secondary monitor → sync dialogs should persist size/position
Target Milestone: 2.0 → mozilla7
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> persist="screenX screenY width height"
Dialogs aren't resizable, so screenX/Y should be enough.
Assignee | ||
Comment 4•14 years ago
|
||
The Sync setup/Sync Key/Add Device wizards are fixed size so just persisting screenX/Y for those. Quota is resizable, so persist width and height there.
Assignee | ||
Updated•14 years ago
|
Whiteboard: [weave1.3]
Comment 5•14 years ago
|
||
Comment on attachment 536140 [details] [diff] [review]
v1
Review of attachment 536140 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #536140 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Whiteboard: [fixed in services]
Assignee | ||
Comment 7•14 years ago
|
||
STRs for QA:
1. Open any of the Sync dialogs (setup wizard, My Sync Key, Change Password, View Quota, etc.)
2. Move them around and change size (latter only possible for View Quota)
3. Close and reopen the dialog. Position and size should have been restored.
Updated•14 years ago
|
Whiteboard: [fixed in services] → [verified in services]
Assignee | ||
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•