564560 - sync dialogs should persist size/position

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tony Chung [:tchung]]

When firefox is moved into a secondary shared monitor space, opening and closing modal dialogs should persist in the same coordinates after reopening.   This isnt true with the Weave setup modal dialog.

Repro:
1) install weave 1.3b5
2) move firefox to a secondary shared monitor
3) fire up prefpane or any other modal dialog (addons manager). then close it
4) reopen, and notice the prefpane or other firefox modal dialog retains it coordinates
5) now do the same action, but this time open prefpane, then sync, and the sync setup dialog page
6) close it all, and reopen
7) Verify sync setup page always defaults back to the same coordinates in the main screen, while everything else is in the secondary monitor screen.

Expected:
- sync setup modal dialog persists its location after closing and reopening

Actual:
- sync setup modal dialog shifts back to main desktop space and its default coordinates.

Comment 1

[Mike Connor [:mconnor]]

needs some persist love for the wizard, not blocking 1.3 though.

Comment 2

[Mike Connor [:mconnor]]

Need to add this to the window/wizard/dialog declarations:

persist="screenX screenY width height"

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/syncQuota.xul#51
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/syncSetup.xul#55

Minor polish fix, but also super trivial.

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to comment #2)
> persist="screenX screenY width height"

Dialogs aren't resizable, so screenX/Y should be enough.

Comment 4

[Philipp von Weitershausen [:philikon]]

Attachment: v1

The Sync setup/Sync Key/Add Device wizards are fixed size so just persisting screenX/Y for those. Quota is resizable, so persist width and height there.

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 536140 [details] [diff] [review]
v1

Review of attachment 536140 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/services-central/rev/443d2b2edbb3

Comment 7

[Philipp von Weitershausen [:philikon]]

STRs for QA:

1. Open any of the Sync dialogs (setup wizard, My Sync Key, Change Password, View Quota, etc.)
2. Move them around and change size (latter only possible for View Quota)
3. Close and reopen the dialog. Position and size should have been restored.

Comment 8

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/443d2b2edbb3

Comment 9

[Tracy Walker [:tracy]]

verified in m-c build from 20110602