687316 - (sync2sm) [Tracking] (Remaining) Sync changes to port to Suite

Status: RESOLVED INCOMPLETE

(SeaMonkey :: Sync UI, defect)

Description

[Justin Wood (:Callek)]

Attachment: hg log of sync files

This bug will be used as a tracker for any *current* Sync patches/bugs that need to be ported to SeaMonkey.

Bugs should be removed from this tracker when they are fixed in our code, and added to deps when they are checked into mozilla-*. All work should be done on new bugs.

I am attaching the output from an hg log from mozilla-central. So many of these bugs will have been ported/handled already, but this should be a good start to get things figured out.

Actual command |(find browser/ -regex .*sync.* -print && hg log -v `find browser/ -regex .*sync.* -print`) > synclog.txt|

Marking r? to Jens so we can get this list triaged and bugs on file.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: narrowed-down list

The attached list is much shorter and likely contains between very few and no false positives. Not all that are listed there actually need to be ported, though. This is just an intermediate result. Please only add bugs as dependencies (or comments) that really need to be ported. If in doubt, ask.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Bug 656492 changed "Sync Key" to "Recovery Key", which is already reflected on SUMO (where several links from Sync UI point to), so we should follow suit. Bug 681519 is a bug fix on top of that.

Bug 660684 is still closed so I cannot add it as a dependency or see what it's actually about, but looking at the corresponding m-c changeset 89822eff0816 I'd say we should also add that line.

Bug 600429 is a false positive, we already ported it in bug 668993.

That's all for now, time to get some sleep. Feel free to add more dep bugs from the list (with reasoning, please) or replace the existing ones with port bugs.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

FTR: We don't need to port bug 690414 since we got it right from the start. :-)

Comment 4

[Frank-Rainer Grahl (:frg)]

Sync 1.1 is gone and 1.5 needs a complete new implementation in Bug 1022319. I think we can close this one and if a Meta is needed open a new one. If you don't agree please reopen.