565378 - Personas:Unable to add a review;Submit fails with errors on page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Go to https://preview.addons.mozilla.org/z/en-US/firefox/addon/85531/
2.Try to add a review

observed behavior:

post fails with -"There are errors in this form. Please correct them and resubmit." message

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Removing the review box for now (parity with remora):

http://skitch.com/davedash/drixr/dash-host-5-41

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commits/bd246a5

Comment 3

[krupa raj[:krupa]]

review section has been disabled for personas in zamboni.

https://preview.addons.mozilla.org/en-US/firefox/addon/85531/

Comment 4

[Ryan Doherty (:rdoherty)]

(In reply to comment #1)
> Removing the review box for now (parity with remora):
> 
> http://skitch.com/davedash/drixr/dash-host-5-41

Why are we matching parity with remora? Bug 554379 was for adding reviews to personas.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Didn't know about that bug.  We're matching parity so we can serve something working live.  At the moment remora - which handles the reviews, doesn't recognize personas as being addons.

When we handle serving reviews from zamboni (soon?) we can uncomment the review box from this.

Comment 6

[Ryan Doherty (:rdoherty)]

(In reply to comment #5)
> Didn't know about that bug.  We're matching parity so we can serve something
> working live.  At the moment remora - which handles the reviews, doesn't
> recognize personas as being addons.
> 
> When we handle serving reviews from zamboni (soon?) we can uncomment the review
> box from this.

Ok, I'll request this for 5.12.