565473 - Port over Add-on Privacy Policy & EULA subpages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Justin Scott [:fligtar]]

Please port over add-on privacy policy and EULA subpages. Right now they are both at /addon/$id/policy but we should break them up in zamboni into:

/addon/$id/eula
/addon/$id/privacy

URLs should be auto-linked (with outgoing.m.o) in both of these documents.

Comment 1

[Justin Scott [:fligtar]]

And please add the breadcrumbs as mentioned in bug 564555

Comment 2

[Wil Clouser [:clouserw]]

Example privacy policy: https://addons.mozilla.org/en-US/firefox/addons/policy/0/3481

Example EULA:
https://addons.mozilla.org/en-US/firefox/addons/policy/0/4286/16199

So yeah, pretty much the same template, except the EULA has an install button on it.  The template is at /views/addons/policy.thtml in remora.

Comment 3

[Sam Keen]

i noticed zamboni already has this in addons/views.py
url('^eula/(?P<file_id>\d+)$', views.eula, name='addons.eula'),

is that something different than the eula page mentioned here? And what's with that file_id that doesn't seem to be used?

Comment 4

[Jeff Balogh (:jbalogh)]

(In reply to comment #3)
> i noticed zamboni already has this in addons/views.py
> url('^eula/(?P<file_id>\d+)$', views.eula, name='addons.eula'),
> 
> is that something different than the eula page mentioned here? And what's with
> that file_id that doesn't seem to be used?

The existing page is a sham I made so I could work with buttons and eulas.  I'm not sure if the eula is attached to a file or a version; feel free to make it do the right thing.

Comment 5

[Sam Keen]

I push my first attempts at these to my git branch
http://github.com/samkeen/zamboni/commit/7324c3cd5541b469930f9bd4efdbe8cd1dbcdbd4

i made quite a few 'assumptions' so would be great if I can get them reviewed.

apps/addons/templates/addons/privacy.html  , I think is good

as for apps/addons/templates/addons/eula.html
page though I still need to work in the file_id, i see the logic in remora but need to port it over.  Would be thankful for any pointer there.

Comment 6

[Sam Keen]

jbalough, clouserw, thx for the feedback

fixes pushed to master
http://github.com/jbalogh/zamboni/commit/a58d9e56d16885a70c99aa65b11c55a6548c1ff2

Privacy policy looks to be working, 
ex: https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/privacy/

but just realized not getting EULA copy 
ex:  https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/eula/

so I will look into that some more

Comment 7

[Wil Clouser [:clouserw]]

(In reply to comment #6)
> jbalough, clouserw, thx for the feedback
> 
> fixes pushed to master
> http://github.com/jbalogh/zamboni/commit/a58d9e56d16885a70c99aa65b11c55a6548c1ff2
> 
> Privacy policy looks to be working, 
> ex: https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/privacy/
> 
> but just realized not getting EULA copy 
> ex:  https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/eula/

That add-on doesn't have a EULA.  Add-ons that do work: https://preview.addons.mozilla.org/z/en-US/firefox/addon/13749/eula/

If an add-on doesn't have a policy or EULA remora redirects back to the detail page.  Seems like we could do something better than that, but for now let's implement that since it's easy.

We also need a redirect from the remora page to zamboni.  Remora URLs (so ugly) look like:

Privacy: https://addons.mozilla.org/en-US/firefox/addons/policy/0/13749
EULA: https://addons.mozilla.org/en-US/firefox/addons/policy/0/13749/86040

We need some legacy redirects in zamboni to keep those URLs alive. (They can permanent redirect to the new URLs)

Comment 8

[Sam Keen]

pushed fixes to master
http://github.com/jbalogh/zamboni/commit/2d1cfbfa85ee066f127e367cece5673b439ca7fe

redirect legacy URL's
Privacy: https://addons.mozilla.org/z/en-US/firefox/addons/policy/0/13749
 -> /firefox/addon/13749/privacy/
EULA: https://addons.mozilla.org/z/en-US/firefox/addons/policy/0/13749/86040
 -> /firefox/addon/13749/eula/86040

redirect to addon detail page if eula or privacy policy are empty
https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/eula/
-> /firefox/addon/3481/

Comment 9

[krupa raj[:krupa]]

verified