Port over Add-on Privacy Policy & EULA subpages

VERIFIED FIXED in 5.11.2

Status

P2
normal
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: fligtar, Assigned: skeen.bugzilla)

Tracking

Dependency tree / graph

Details

(Whiteboard: [z][qa+][loadtest+])

(Reporter)

Description

9 years ago
Please port over add-on privacy policy and EULA subpages. Right now they are both at /addon/$id/policy but we should break them up in zamboni into:

/addon/$id/eula
/addon/$id/privacy

URLs should be auto-linked (with outgoing.m.o) in both of these documents.
(Reporter)

Comment 1

9 years ago
And please add the breadcrumbs as mentioned in bug 564555
Blocks: 564555
Example privacy policy: https://addons.mozilla.org/en-US/firefox/addons/policy/0/3481

Example EULA:
https://addons.mozilla.org/en-US/firefox/addons/policy/0/4286/16199

So yeah, pretty much the same template, except the EULA has an install button on it.  The template is at /views/addons/policy.thtml in remora.
Assignee: nobody → skeen.bugzilla
Target Milestone: 5.11.1 → 5.11.2
(Assignee)

Comment 3

8 years ago
i noticed zamboni already has this in addons/views.py
url('^eula/(?P<file_id>\d+)$', views.eula, name='addons.eula'),

is that something different than the eula page mentioned here? And what's with that file_id that doesn't seem to be used?
(In reply to comment #3)
> i noticed zamboni already has this in addons/views.py
> url('^eula/(?P<file_id>\d+)$', views.eula, name='addons.eula'),
> 
> is that something different than the eula page mentioned here? And what's with
> that file_id that doesn't seem to be used?

The existing page is a sham I made so I could work with buttons and eulas.  I'm not sure if the eula is attached to a file or a version; feel free to make it do the right thing.
(Assignee)

Comment 5

8 years ago
I push my first attempts at these to my git branch
http://github.com/samkeen/zamboni/commit/7324c3cd5541b469930f9bd4efdbe8cd1dbcdbd4

i made quite a few 'assumptions' so would be great if I can get them reviewed.

apps/addons/templates/addons/privacy.html  , I think is good

as for apps/addons/templates/addons/eula.html
page though I still need to work in the file_id, i see the logic in remora but need to port it over.  Would be thankful for any pointer there.
Status: NEW → ASSIGNED
Whiteboard: [z] → [z][qa+][loadtest?]
(Assignee)

Comment 6

8 years ago
jbalough, clouserw, thx for the feedback

fixes pushed to master
http://github.com/jbalogh/zamboni/commit/a58d9e56d16885a70c99aa65b11c55a6548c1ff2

Privacy policy looks to be working, 
ex: https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/privacy/

but just realized not getting EULA copy 
ex:  https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/eula/

so I will look into that some more
(In reply to comment #6)
> jbalough, clouserw, thx for the feedback
> 
> fixes pushed to master
> http://github.com/jbalogh/zamboni/commit/a58d9e56d16885a70c99aa65b11c55a6548c1ff2
> 
> Privacy policy looks to be working, 
> ex: https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/privacy/
> 
> but just realized not getting EULA copy 
> ex:  https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/eula/

That add-on doesn't have a EULA.  Add-ons that do work: https://preview.addons.mozilla.org/z/en-US/firefox/addon/13749/eula/

If an add-on doesn't have a policy or EULA remora redirects back to the detail page.  Seems like we could do something better than that, but for now let's implement that since it's easy.

We also need a redirect from the remora page to zamboni.  Remora URLs (so ugly) look like:

Privacy: https://addons.mozilla.org/en-US/firefox/addons/policy/0/13749
EULA: https://addons.mozilla.org/en-US/firefox/addons/policy/0/13749/86040

We need some legacy redirects in zamboni to keep those URLs alive. (They can permanent redirect to the new URLs)
(Assignee)

Comment 8

8 years ago
pushed fixes to master
http://github.com/jbalogh/zamboni/commit/2d1cfbfa85ee066f127e367cece5673b439ca7fe

redirect legacy URL's
Privacy: https://addons.mozilla.org/z/en-US/firefox/addons/policy/0/13749
 -> /firefox/addon/13749/privacy/
EULA: https://addons.mozilla.org/z/en-US/firefox/addons/policy/0/13749/86040
 -> /firefox/addon/13749/eula/86040

redirect to addon detail page if eula or privacy policy are empty
https://preview.addons.mozilla.org/z/en-US/firefox/addon/3481/eula/
-> /firefox/addon/3481/
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Depends on: 572844
Whiteboard: [z][qa+][loadtest?] → [z][qa+][loadtest+]

Comment 9

8 years ago
verified
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.