565498 - Port add-on share subpage/redirecter to zamboni

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Justin Scott [:fligtar]]

Please port /addon/share/$id to /addon/$id/share in zamboni

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to comment #1)
> Created an attachment (id=446665) [details]
> Screenshot

Do you really have a bright yellow title bar all the time?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=446665) [details] [details]
> > Screenshot
> 
> Do you really have a bright yellow title bar all the time?

Nah, only when I anticipate or want you to ask me a question about it.

Comment 4

[Wil Clouser [:clouserw]]

No front-end work here, but this page accepts/validates/sends emails as well as forwarding people to services.

Comment 5

[Barry Chen]

http://github.com/chenba/zamboni/commit/cd15021f32c242622ce08e8f302215284f481feb

Comment 6

[Wil Clouser [:clouserw]]

Thanks chenba.  Moving this to 5.12.1 so it's after the amo-detractors meeting.

Comment 7

[Barry Chen]

All right, jbalogh mentioned that he has something in the zamboni sharing app that "takes care of everything" besides email sharing, and now e-mail sharing is getting dropped, _and_ there's bug 600664.  So do I need to do anything with this bug?

Comment 8

[Wil Clouser [:clouserw]]

(In reply to comment #7)
> All right, jbalogh mentioned that he has something in the zamboni sharing app
> that "takes care of everything" besides email sharing, and now e-mail sharing
> is getting dropped, _and_ there's bug 600664.  So do I need to do anything with
> this bug?

Yeah, I don't know what "takes care of everything" means either.  We want all the sharing options except email.  jbalogh?

Comment 9

[Jeff Balogh (:jbalogh)]

I have http://github.com/jbalogh/zamboni/blob/master/apps/sharing/views.py doing all the sharing logic, so we just need an view in add-ons that calls it with the right params.

I think we can skip the redirect since this is an internal-ish view.

Barry, if you still want to work on this you can dupe one of the bugs.  I was so excited about dropping email sharing that I forgot about this one.

Comment 10

[Barry Chen]

Aww, I don't have the authoritay mark bug 600664 as a duplicate.

Comment 12

[Barry Chen]

http://github.com/chenba/zamboni/commit/6f12cfc6de5389bb191d26983d10732534960e76

Redirect sharing now uses sharing.views.share as suggested by jbalogh; e-mail sharing no longer in the port.

Comment 13

[Barry Chen]

http://github.com/chenba/zamboni/commit/88fa574001a3e355858c94743562c65df2091889

Trimmed and changed some code based on jbalogh's input.

Also, the version is no long part of the addon title in the redirect params.  If there's good reason to keep it, please explain.

Comment 14

[Barry Chen]

http://github.com/chenba/zamboni/commit/0d1fc802d47edd179618c8e98a585cc86ddb6f57

Named arguments for readability.

Comment 15

[Wil Clouser [:clouserw]]

http://github.com/jbalogh/zamboni/commit/647406df5ae3d6c5189d2c0a6d15e712ccaedb07

Comment 16

[Wil Clouser [:clouserw]]

(In reply to comment #15)
> http://github.com/jbalogh/zamboni/commit/647406df5ae3d6c5189d2c0a6d15e712ccaedb07

And with that:  Thanks, -> FIXED

Comment 17

[krupa raj[:krupa]]

checked that the following links work fine-

/en-US/firefox/addon/4882/share?service=digg
/en-US/firefox/addon/4882/share?service=facebook
/en-US/firefox/addon/4882/share?service=delicious
/en-US/firefox/addon/4882/share?service=myspace
/en-US/firefox/addon/4882/share?service=friendfeed
/en-US/firefox/addon/4882/share?service=twitter

Comment 18

[Jeff Balogh (:jbalogh)]

Did you test with personas?

Comment 19

[krupa raj[:krupa]]

(In reply to comment #18)
> Did you test with personas?

bug 599985 is still open. I do not see any way to share personas @ https://preview.addons.mozilla.org/en-US/firefox/addon/15105/

Am I missing something?