565801 - [k] Internal links should check page exists

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P4)

Description

[Paul Craciunoiu [:paulc]]

Follow-up from a github discussion over bug 561524, we'd like to make the internal link hook smarter by checking if the KB page exists, and include an edit-link instead, if it doesn't.

Comment 1

[James Socol [:jsocol, :james]]

This can slip.

Comment 2

[Paul Craciunoiu [:paulc]]

Up for grabs if anyone else wants it.

Comment 3

[Paul Craciunoiu [:paulc]]

http://github.com/jsocol/kitsune/commit/dbe6e48cac03362e6c93c00e67876ec5becdc57e (and previous commit)

Comment 4

[Paul Craciunoiu [:paulc]]

Testing this:
* If the wiki page exists (e.g. "Installing Firefox"), the resulting link should take you to the KB page (e.g. /<locale>/kb/Installing+Firefox)
* If the wiki page does not exist (e.g. "Does Not Exist"), the resulting link should take you to the edit page (e.g. "/tiki-editpage.php?page=Does+Not+Exist")

Comment 5

[James Socol [:jsocol, :james]]

(In reply to comment #4)
> * If the wiki page does not exist (e.g. "Does Not Exist"), the resulting link
> should take you to the edit page (e.g.
> "/tiki-editpage.php?page=Does+Not+Exist")

Technically, it should take you to the creation page.

Comment 6

[Rebecca Billings [:rbillings]]

I'm not seeing the creation page when altering the page name:
https://support-stage.mozilla.com/en-US/forum/1/572911?s=not+a+page&as=s

Changing the forum number brings up the 'error incorrect thread' page:
https://support-stage.mozilla.com/en-US/forum/1/572948371?s=not+a+page&as=s

Comment 7

[Rebecca Billings [:rbillings]]

Verified using page paths for valid and invalid pages inside question/answer