569033 - [k] Implement the ability to insert images (or image paths)

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P1)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

This probably needs discussion outside of the bug (or wherever you guys choose), but we should implement the ability to insert images, or image paths (via wiki markup).

Comment 1

[Paul Craciunoiu [:paulc]]

Adding links to wiki pages makes it better to land bug 565801 first. Easy enough.

Comment 2

[Paul Craciunoiu [:paulc]]

Fix in py-wikimarkup to allow custom ALLOWED_TAGS and ALLOWED_ATTRIBUTES:

http://github.com/pcraciunoiu/py-wikimarkup/commit/12fca59b62fa1bb2b979421cc301a726095fbd56

Comment 3

[Paul Craciunoiu [:paulc]]

This is mostly done. CSS left, and any other issues found by reviewers :)

Comment 4

[Rebecca Billings [:rbillings]]

Test case for review:
https://litmus.mozilla.org/manage_testcases.cgi?testcase_id=11913

Comment 5

[Rebecca Billings [:rbillings]]

Better test link:
https://litmus.mozilla.org/show_test.cgi?id=11913

Comment 6

[Paul Craciunoiu [:paulc]]

http://github.com/jsocol/kitsune/commit/4c93487326b5c1f9d73eb2868e578eab680dfe0f

Syntax documentation available here:
http://wiki.github.com/jsocol/kitsune/syntax-for-inserting-images

QA: Upload support is coming in bug 578520, so until then you can use the Tiki side (tiki forums or KB) to upload images for testing.

Comment 7

[Rebecca Billings [:rbillings]]

Verified able to insert images on the KB, waiting on bug 578520 to test the rest.

Comment 8

[Paul Craciunoiu [:paulc]]

Ah, I should have been clear. Syntax support is already there. The point of uploading images to the KB was so you can use these images to insert them in the forum and question posts. For example, try this:

[[Image:5987269c70c0b84cbd6797a11af336b2-1279569434-782-1.jpg|animal]]

I started it in here so you can get a sense of what I mean:
https://support-stage.mozilla.com/en-US/forums/too-many-forums/695199

Bug 578520 will actually allow you to upload images and insert them on the same (Kitsune!) page, and add a nice UI for the whole thing.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.com/en-US/questions/37#question-form; so cute!

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Rebecca: I think you can just verify the rest over in bug 578520; thanks!

Comment 12

[Paul Craciunoiu [:paulc]]

That seems to test just the basic syntax. You may want to play around with the syntax options from the documentation link comment 6, to make sure they all work as expected.

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Yeah, good point.  Let me just re-close so we'll be sure to hit this again, more thoroughly.  Sorry for the spam.

Comment 14

[Rebecca Billings [:rbillings]]

Tested with more variations listed on the image insert syntax page, all checks out.