565820 - [FIX]Switch nsReferencedElement to use Element

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It knows it has Elements anyway; this makes life a little simpler for some consumers.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 445273 [details] [diff] [review]
Like so

I think I'd prefer to have
  typedef mozilla::dom::Element Element;

in classes that need it instead of writing "mozilla::dom::Element" all over the place, as a general rule. Does that sound reasonable?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: With typedefs

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Be careful with typedefs, they don't seem to always work on Windows.
using might be better. See for example bug 555573.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Though, bug 555573 had a bit different case. There the typedef was outside class
declaration.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We've been using in-class typedefs in media and layer code for a while now.

Comment 7

[Boris Zbarsky [:bzbarsky]]

I did run all this through the tryserver and it looks ok.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/6363de2781b3