Closed Bug 565820 Opened 10 years ago Closed 10 years ago

[FIX]Switch nsReferencedElement to use Element

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(2 files)

It knows it has Elements anyway; this makes life a little simpler for some consumers.
Attached patch Like soSplinter Review
Attachment #445273 - Flags: review?(roc)
Summary: [FIX]Switched nsReferencedElement to use Element. → [FIX]Switch nsReferencedElement to use Element
Comment on attachment 445273 [details] [diff] [review]
Like so

I think I'd prefer to have
  typedef mozilla::dom::Element Element;

in classes that need it instead of writing "mozilla::dom::Element" all over the place, as a general rule. Does that sound reasonable?
Attachment #445273 - Flags: review?(roc) → review+
Be careful with typedefs, they don't seem to always work on Windows.
using might be better. See for example bug 555573.
Though, bug 555573 had a bit different case. There the typedef was outside class
declaration.
We've been using in-class typedefs in media and layer code for a while now.
I did run all this through the tryserver and it looks ok.
Pushed http://hg.mozilla.org/mozilla-central/rev/6363de2781b3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.