Closed Bug 565882 Opened 14 years ago Closed 12 years ago

'make package' and 'make sdk' for xulrunner on Windows shouldn't put files into 'unsigned'

Categories

(Release Engineering :: General, defect, P5)

Product:
Release Engineering
Component:
General
Platform:
x86
Windows Server 2003
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 627182

People

(Reporter: bhearsum, Assigned: rail)

Details

(Whiteboard: [automation]) 

We don't signcode sign these builds so they shouldn't go in 'unsigned' dirs.
Priority: -- → P3
Priority: P3 → P5
OS: Mac OS X → Windows Server 2003
Hardware: All → x86
Whiteboard: [automation]
Shouldn't we move this bug to Core/Build config?
Yes, you're right
Component: Release Engineering → Build Config
Product: mozilla.org → Core
QA Contact: release → build-config
Version: other → unspecified
We actually append this in post_upload.py at
 http://hg.mozilla.org/build/tools/file/default/stage/post_upload.py#l178

I'm wondering if line 178 should be a white list of apps that do real signing, ie
  if 'win32' in f and options.product in ('firefox', 'thunderbird'):
Component: Build Config → Release Engineering
Product: Core → mozilla.org
QA Contact: build-config → release
Version: unspecified → other
(In reply to comment #3)
> I'm wondering if line 178 should be a white list of apps that do real signing,
> ie
>   if 'win32' in f and options.product in ('firefox', 'thunderbird'):

As mentioned in IRC, I [for seamonkey] am perfectly ok with this suggestion.
Nick: sounds fine to me, as long as thunderbird is in that list. :)
Great! Do I need to include anything from calendar ?
Assignee: nobody → rail
Will be done as a part of xulrunner signing automation.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.