627182 - Automate signing and publishing of XULRunner builds

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

We do these steps manually
 https://wiki.mozilla.org/Releases/Firefox_3.6.13/BuildNotes#XULRunner_Signing
to create a XULRunner release to match each Firefox release. We should automate it too.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

With this, bug 565882, and a push to mirrors builder, we would pretty much have automated XULRunner builds.

Comment 2

[[e-mail] (:bhearsum)]

The signing portion of this is fixed by bug 509158, I think?

Comment 3

[Rail Aliiev [:rail]]

Attachment: tools

* generate checksums: allow override product, ssh user name/key
* push to mirrors:  allow override product, ssh user name/key; shouldn't exclude zip files for xulrunner

to be tested

Comment 4

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

* Uploads files to win32 instead of unsigned/win32 (post_upload.py --signed ...)
* Generates MD5/SHA1/SHA512SUMS files automatically
* Pushes to the internal mirrors just after checksums generation

Comment 6

[Rail Aliiev [:rail]]

Attachment: tools

Comments incoming

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 605931 [details] [diff] [review]
tools

Review of attachment 605931 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/release/generate-sums.py
@@ +96,5 @@
> +    if productName == 'firefox':
> +        cmd = 'mkdir -v -m 2775 %s/contrib %s/contrib-localized' % \
> +            (candidatesDir, candidatesDir)
> +        run_remote_cmd(cmd, server=stageServer, username=stageUsername,
> +                       sshKey=stageSshKey)

candidates are applicable to firefox only.

::: scripts/release/push-to-mirrors.py
@@ -29,5 @@
>  DEFAULT_RSYNC_EXCLUDES = ['--exclude=*tests*',
>                            '--exclude=*crashreporter*',
>                            '--exclude=*.log',
>                            '--exclude=*.txt',
> -                          '--exclude=*.zip',

Xulrunner needs *.zip files (SDK)

Comment 8

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

This enables signing on demand for Xulrunner. The patch shouldn't be landed unless we are sure that there is no 11.0 chemspill or we need to land the build system patches to m-r.

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 605931 [details] [diff] [review]
tools

Review of attachment 605931 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/release/generate-sums.py
@@ +96,5 @@
> +    if productName == 'firefox':
> +        cmd = 'mkdir -v -m 2775 %s/contrib %s/contrib-localized' % \
> +            (candidatesDir, candidatesDir)
> +        run_remote_cmd(cmd, server=stageServer, username=stageUsername,
> +                       sshKey=stageSshKey)

Can we find a better way of doing this than special casing the product, please? I think it's better to pass an explicit --create-contrib option (or maybe --no-contrib) from release.py since we're already forced into special casing things there.

::: scripts/release/push-to-mirrors.py
@@ +165,5 @@
> +    stageSshKey = options.ssh_key or branchConfig["stage_ssh_key"]
> +    stageSshKey = path.join(os.path.expanduser("~"), ".ssh", stageSshKey)
> +
> +    if productName != 'xulrunner':
> +        DEFAULT_RSYNC_EXCLUDES.append('--exclude=*.zip')

Similar thing here. I'm not sure if it's better to have an --exclude-zip option or --additional-exclude=*.zip though.

Comment 10

[Rail Aliiev [:rail]]

Attachment: tools

To be tested

Comment 11

[Rail Aliiev [:rail]]

Attachment: buildbotcustom

Comment 12

[Rail Aliiev [:rail]]

Attachment: builbotcustom

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 607148 [details] [diff] [review]
tools

worked fine in staging

Comment 14

[Rail Aliiev [:rail]]

Comment on attachment 607148 [details] [diff] [review]
tools

http://hg.mozilla.org/build/tools/rev/a540057c0257

Comment 15

[Rail Aliiev [:rail]]

Comment on attachment 608726 [details] [diff] [review]
builbotcustom

http://hg.mozilla.org/build/buildbotcustom/rev/19db1875ce2e

Comment 16

[Rail Aliiev [:rail]]

bustage found, thanks to jhford:
AssertionError: <buildbotcustom.scheduler.AggregatingScheduler instance at 0x13eb2320> uses unknown builder release-mozilla-1.9.2-xulrunner_checksums

patch incoming

Comment 17

[Rail Aliiev [:rail]]

Attachment: extra checks

Added extra checks. git diff -b (ignore blanks) looks like https://gist.github.com/2211305

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 609564 [details] [diff] [review]
extra checks

looks good to me

Comment 19

[Rail Aliiev [:rail]]

Comment on attachment 609564 [details] [diff] [review]
extra checks

http://hg.mozilla.org/build/buildbotcustom/rev/1e0277f9acb8

Comment 20

[[e-mail] (:bhearsum)]

Bulk move of bugs to Release Automation component.

Comment 21

[[e-mail] (:bhearsum)]

Mass move of bugs to Release Automation component.

Comment 22

[John Ford [:jhford] CET/CEST Berlin Time]

this was deployed during a reconfig today

Comment 23

[Rail Aliiev [:rail]]

Attachment: missing post_upload param

Somehow, the attached hunk hasn't been applied to the final push. :/
win32 build went to unsigned in 12.0b3

Comment 24

[[e-mail] (:bhearsum)]

Comment on attachment 610132 [details] [diff] [review]
missing post_upload param

Review of attachment 610132 [details] [diff] [review]:
-----------------------------------------------------------------

d'oh!

Comment 25

[Rail Aliiev [:rail]]

(In reply to Rail Aliiev [:rail] from comment #23)
> Created attachment 610132 [details] [diff] [review]
> missing post_upload param
> 
> Somehow, the attached hunk hasn't been applied to the final push. :/
> win32 build went to unsigned in 12.0b3

Actually it was removed by another patch http://hg.mozilla.org/build/buildbotcustom/rev/8aff61059e92#l3.563

Comment 26

[Armen [:armenzg]]

These changes went live around 11:55AM PDT.