565887 - window.sizeToContent breaks layout in Fennec main window

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Extension Compatibility, defect)

Description

[ahoza]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0(X11;U;Linux armv7l;Nokia N900; en-US;rv:1.9.2.5pre) Gecko/20100513 Namoroka/3.6.5pre Fennec 1.1b2pre 

Improper display in Options->Add-ons->Options button on an installed add-on. If leaving Options menu, user cannot return unless he restarts browser.

Reproducible: Always

Steps to Reproduce:
1.Start Fennec
2.Go to Options->Add-ons.
3.Select an installed extension and then Options.
4. Select Options button to leave the menu.
5. While in page, pan screen to the left to access Options again. 
Actual Results:  
Controls and text are not entirely visible after executing step 4. (see screen capture attached)
For step 5 - when panning screen to left, Options button (and all the rest of the buttons that should be available: Bookmark, Back, Forward) are not displayed.

Expected Results:  
Add-on's options should be displayed properly.
User should be able to return to Options, from the web page.

Comment 1

[ahoza]

Attachment: Screen capture

See attached screen capture.

Comment 3

[Aakash Desai [:aakashd]]

Nominating this as blocking-fennec since it's a recommended add-on.

Comment 4

[Christopher Finke]

I can update TwitterBar to work around this in order to avoid having this bug be a blocker if that would help. (Or is this bug actually a TwitterBar bug itself?)

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> I can update TwitterBar to work around this in order to avoid having this bug
> be a blocker if that would help. (Or is this bug actually a TwitterBar bug
> itself?)

Obviously that's a bug on the Fennec Front-End side, we should not let addons grow more than the allowed width.

If we consider this bug as a blocker for 1.1, I can look at it.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien, I think we should look for a fix to the <setting> code. I don't know if this should block though.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

I found that rotating the device to cause an orientation change fixed the problem.

Digging into the problem, I found a "sizeToContent" in the TwitterBar options.js code. This seems to be the culprit.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

To be clear, Fennec <setting> already has the proper crop= and flex= attributes on labels. This issue seems to happen entirely because of the "sizeToContent". Stubbing out the call fixed the problem.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch stubs out "sizeToContent" in the Fennec main window. Using it will report an error in the JS console. The error is not harmful, just a message to developers.

We only need to do this in the Fennec main window.

Also, I only saw the original issue on device, not on desktop. So for testing, you need a device.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Updating the summary

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 446514 [details] [diff] [review]
patch

Could we not write the function on only one line?

Comment 12

[Christopher Finke]

(In reply to comment #7)
> Digging into the problem, I found a "sizeToContent" in the TwitterBar
> options.js code. This seems to be the culprit.

Thanks for finding this; I've made the appropriate changes so that the next version of TwitterBar doesn't make this call in Fennec.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/fecde29347e9

pushed to m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/c5c9537e9dd8

Comment 14

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.5pre) Gecko/20100521 Namoroka/3.6.5pre Fennec/1.1b2pre