Closed Bug 565904 Opened 15 years ago Closed 15 years ago

HTMLOptGroupElement and HTMLOptionElement are not form controls but are listed in nsIFormControl

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Patch v1 (obsolete) — Splinter Review
HTMLOptGroupElement isn't a form control so it should not be listed in nsIFormControl.
Attachment #445353 - Flags: review?(Olli.Pettay)
Summary: HTMLOptGroupElement is not a form control but listed in nsIFormControl → HTMLOptGroupElement and HTMLOptionElement are not form controls but are listed in nsIFormControl
Attached patch Patch v2 (obsolete) — Splinter Review
This patch is also removing NS_FORM_OPTION from nsIFormControl.
Attachment #445353 - Attachment is obsolete: true
Attachment #445360 - Flags: review?(Olli.Pettay)
Attachment #445353 - Flags: review?(Olli.Pettay)
Attachment #445360 - Flags: review?(Olli.Pettay) → review+
Attached patch Patch v2.1Splinter Review
r=smaug Patch updated to apply on current tip.
Attachment #445360 - Attachment is obsolete: true
Keywords: checkin-needed
I landed this, but backed it out because I thought it might have caused test failures. However, it seems the test failures were not caused by this patch, so it should be relanded.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: