Closed Bug 566142 Opened 11 years ago Closed 9 years ago

accountSetupInfo.label text is not right anymore

Categories

(Thunderbird :: Account Manager, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 9.0

People

(Reporter: mad_maks, Assigned: mad_maks)

References

Details

(Keywords: polish)

Attachments

(1 file, 2 obsolete files)

if you click "Add Other Account…" in thunderbird  you get the "old" acountwizard screen. You can choose between newsgroups or blog. the text in this window is still about set up a Mail or Newsgroup account
Tim would you mind coming up with an alternative text ?
Keywords: polish
Attached patch alternative text (obsolete) — Splinter Review
proposal for the account manager
is this still on the radar?
Would you be willing to complete the patch?

It would certainly be helpful to request ui-review on your proposed text first - on the attachment, set ui-review to "?" and enter :clarkbw in the address.
Attachment #449513 - Flags: ui-review?(clarkbw)
Attachment #449513 - Flags: ui-review?(clarkbw) → ui-review?(bwinton)
Maybe what we should really do here is remove the first page of the wizard, create a separate wizard for each other account type, and add each of them to the File -> New submenu. I think that would be, at most, 2 more menu items (since Linux has 3 non-mail account types).
Comment on attachment 449513 [details] [diff] [review]
alternative text

Review of attachment 449513 [details] [diff] [review]:
-----------------------------------------------------------------

I agree with Jim that the non-mail account creation could use a bit of an overhaul, but that seems like a different bug.  So, to make things a little better in the meantime, ui-r=me, with the typos below fixed.  (And I'm going to go ahead and give it an r=me, while I'm here.)

Thanks,
Blake.

::: mail/locales/en-US/chrome/messenger/AccountWizard.dtd
@@ -9,2 +9,2 @@
> >  <!ENTITY accountTypeTitle.label "New Account Setup">
> > -<!ENTITY accountTypeDesc.label "This Wizard will collect the information necessary to set up a Mail or Newsgroup account. If you do not know the information requested, please contact your System Administrator or Internet Service Provider.">
> > +<!ENTITY accountTypeDesc1.label "This Wizard will collect the information necessary to set up a account. If you do not know the information requested, please contact your System Administrator or Internet Service Provider.">

Typo: "to set up a account" should be "to set up an account", in both strings.
Attachment #449513 - Flags: ui-review?(bwinton)
Attachment #449513 - Flags: ui-review+
Attachment #449513 - Flags: review+
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Tim can you make a new patch taking into account comment 6 ?
Attached patch patch version 2 (obsolete) — Splinter Review
New patch, i didn't change the entity name as i did in version 1. It looks like if i do that i have to change the text also in seamonkey.
Attachment #449513 - Attachment is obsolete: true
Attachment #546505 - Flags: ui-review?(bwinton)
Attachment #546505 - Flags: review?(bwinton)
Comment on attachment 546505 [details] [diff] [review]
patch version 2

Hi,

First of all thanks for taking the time to provide an updated patch. However, you do need to change the entity names, otherwise, the l10n people will fail to figure out the text has changed. Please submit an updated patch. Feel free to set already "ui-review+" on it, since Blake has expressed his agreement earlier.

Concerning the SeaMonkey issue, if you submit a patch that affects SeaMonkey, as I understand it, it's perfectly acceptable to just CC some person from SeaMonkey (say, IanN or RattyAway) to notify them of the change.

Keep up the good work!
Attachment #546505 - Flags: ui-review?(bwinton)
Attachment #546505 - Flags: ui-review+
Attachment #546505 - Flags: review?(bwinton)
Attachment #546505 - Flags: review-
(In reply to comment #9)
> Comment on attachment 546505 [details] [diff] [review] [review]
> patch version 2
> 
> Hi,
> 
> First of all thanks for taking the time to provide an updated patch.
> However, you do need to change the entity names, otherwise, the l10n people
> will fail to figure out the text has changed. Please submit an updated
> patch. Feel free to set already "ui-review+" on it, since Blake has
> expressed his agreement earlier.
> 
> Concerning the SeaMonkey issue, if you submit a patch that affects
> SeaMonkey, as I understand it, it's perfectly acceptable to just CC some
> person from SeaMonkey (say, IanN or RattyAway) to notify them of the change.
> 
> Keep up the good work!

I know how important the entity name change is, that is why i did it in the first patch ( i am a localizer). But i was not sure how to handle it with seamonkey, that's why i reported it #8.

i will make a new patch

what are the bugzillaaccounts of IanN or RattyAway, i can't find them.
(In reply to comment #10)
> (In reply to comment #9)
> > Comment on attachment 546505 [details] [diff] [review] [review] [review]
> > patch version 2
> > 
> > Hi,
> > 
> > First of all thanks for taking the time to provide an updated patch.
> > However, you do need to change the entity names, otherwise, the l10n people
> > will fail to figure out the text has changed. Please submit an updated
> > patch. Feel free to set already "ui-review+" on it, since Blake has
> > expressed his agreement earlier.
> > 
> > Concerning the SeaMonkey issue, if you submit a patch that affects
> > SeaMonkey, as I understand it, it's perfectly acceptable to just CC some
> > person from SeaMonkey (say, IanN or RattyAway) to notify them of the change.
> > 
> > Keep up the good work!
> 
> I know how important the entity name change is, that is why i did it in the
> first patch ( i am a localizer). But i was not sure how to handle it with
> seamonkey, that's why i reported it #8.
> 
> i will make a new patch
> 
> what are the bugzillaaccounts of IanN or RattyAway, i can't find them.

As you need to change the entity names then, yes, any new patch will need the changes replicating to SeaMonkey as, even though we have shared code (/mailnews/base/prefs/content/AccountWizard.xul), we have forked locale files. The equivalent in SeaMonkey is at:
/suite/locales/en-US/chrome/mailnews/pref/AccountWizard.dtd
The new entity names could be created as simply as changing the .label to .desc so they become:
accountSetupInfo.desc
accountTypeDesc.desc
but those names would have to pass reviews from both the TB and SM side (another option would be .description)
This patch change also the entityname, for thunderbird and seamonkey
Attachment #546505 - Attachment is obsolete: true
Attachment #554720 - Flags: ui-review+
Attachment #554720 - Flags: review?(jonathan.protzenko)
Comment on attachment 554720 [details] [diff] [review]
accountwizard patch v3

Review of attachment 554720 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me. Thanks for your work!
Attachment #554720 - Flags: review?(jonathan.protzenko) → review+
Comment on attachment 554720 [details] [diff] [review]
accountwizard patch v3

Also requesting review from IanN since it touches SeaMonkey.
Attachment #554720 - Flags: review?(iann_bugzilla)
Attachment #554720 - Flags: review?(iann_bugzilla) → review+
Who is going to commit this patch? i don't know if i have the rights to do it.
(In reply to Tim Maks van den Broek from comment #15)
> Who is going to commit this patch? i don't know if i have the rights to do
> it.

the checking needed keyword is there for that.
Keywords: checkin-needed
(In reply to Ludovic Hirlimann [:Usul] from comment #16)
> (In reply to Tim Maks van den Broek from comment #15)
> > Who is going to commit this patch? i don't know if i have the rights to do
> > it.
> 
> the checking needed keyword is there for that.

still learning ;-) thanks
Hi,

Thanks for the patch! I just committed it and it should be in Thunderbird 9. In the future, what would make my life easier is the instructions outlined in there http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed ; I just committed 11 patches and, that's a lot of work :-).

http://hg.mozilla.org/comm-central/rev/d3766b4e5b7b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
Blocks: 658184
You need to log in before you can comment on or make changes to this bug.