Closed
Bug 566246
Opened 14 years ago
Closed 14 years ago
Merge libnestegg to mozilla-central
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | alpha5+ |
People
(Reporter: roc, Assigned: kinetik)
References
Details
Attachments
(1 file, 4 obsolete files)
83.20 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
Need to extract the patches from mozilla-webmedia, attach a unified patch here and get reviews.
Updated•14 years ago
|
Group: mozilla-corporation-confidential
Assignee | ||
Comment 1•14 years ago
|
||
Import media/libnestegg and toolkit/content/license.html changes. Does not include any changes to the build system--they should be included in the patch attached to the import libvpx bug.
Assignee | ||
Comment 2•14 years ago
|
||
Note that this imports a newer version of libnestegg than we included in the nightly-webm dev builds.
Assignee | ||
Updated•14 years ago
|
Attachment #446433 -
Flags: review?(chris.double)
Comment 3•14 years ago
|
||
Comment on attachment 446433 [details] [diff] [review] import libnestegg v0 r+ with the changes below > diff --git a/media/libnestegg/include/nestegg.h b/media/libnestegg/include/nestegg.h > @code > nestegg * ctx; > nestegg_init(&ctx, io); Documentation is out of date to the implementation. Missing log parameter. > /** User supplied read callback. > @param buffer Buffer to read data into. > @param length Length of supplied buffer in bytes. > @param userptr The #userdata supplied by the user. > @retval 1 Read succeeded. > @retval 0 End of stream. > @retval -1 Error. */ > int (* read)(void * buffer, size_t length, void * userdata); Documentation says the last parameter is 'userptr' but it is 'userdata'. > @retval #NESTEGG_TRACK_VIDEO Track type is audio. Should be NESTEGG_TRACK_AUDIO diff --git a/media/libnestegg/src/nestegg.c b/media/libnestegg/src/nestegg.c >#if 0 >static void >pool_free(void * p) >{ > h_free(p); >} >#endif Unused code/comment. >#if 0 >static int >get_int(struct ebml_type type, int64_t * value) >{ > if (!type.read) > return -1; > > assert(type.type == TYPE_INT); > > *value = type.v.i; > > return 0; >} >#endif Unused code/comment.
Attachment #446433 -
Flags: review?(chris.double) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Address review comments. Also includes upstream change (http://github.com/kinetiknz/nestegg/commit/8977670dd9c04bd4984a329595fafac8f6100f3e) to ignore track timecode scale, as this is not supported in WebM.
Attachment #446433 -
Attachment is obsolete: true
Attachment #447275 -
Flags: review+
Assignee | ||
Comment 5•14 years ago
|
||
Same as v1 but update.sh is updated to reflect autotoolified directory structure of nestegg and copyright is assigned to MoFo.
Attachment #447275 -
Attachment is obsolete: true
Attachment #447415 -
Flags: review+
Assignee | ||
Comment 6•14 years ago
|
||
Same as v2, but moves stdint.h cruft out to a separate file.
Attachment #447415 -
Attachment is obsolete: true
Attachment #447435 -
Flags: review+
Assignee | ||
Comment 7•14 years ago
|
||
Sorry for the bugspam. Same as v3, but includes seek-to-end fix from http://github.com/kinetiknz/nestegg/commit/f9b8ff50024a9c6cc768249a19ce7a2107cf83f9. Rerequesting review as this includes a logic change.
Attachment #447435 -
Attachment is obsolete: true
Attachment #447470 -
Flags: review?(chris.double)
Assignee | ||
Comment 8•14 years ago
|
||
We should probably add libnestegg to https://wiki.mozilla.org/ThirdPartyCode when we check in.
Updated•14 years ago
|
Attachment #447470 -
Flags: review?(chris.double) → review+
Comment 9•14 years ago
|
||
We want WebM support in alpha 5, marking as a blocker.
blocking2.0: --- → alpha5+
Comment 10•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b391708e9552
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Depends on: CVE-2015-4511
You need to log in
before you can comment on or make changes to this bug.
Description
•