566265 - Search index should not contain add-ons with no valid versions

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Pratibha]

Add-on name: Keychain Services Integration:
Details page URL: https://preview.addons.mozilla.org/en-US/firefox/addon/13509/

Result: Page Not Found message is displayed

Comment 1

[Wil Clouser [:clouserw]]

This is caused by addon.current_version being None.  The .extra() in this commit does it: http://github.com/jbalogh/zamboni/commit/b33d887a3ebe6070914d79f09dbbbdf947384a63

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Screenshot

https://preview.addons.mozilla.org/en-US/admin/addons?q=[13509] (see screenshot) says this works as expected: The add-on has no versions that are public and only public (which is exactly what bug 558237 asked for). I think this behavior is reasonable because it's not too much asked that if an author wants their add-on to be seen, they should have at least one version whose files all match their add-on status.

That would make this bug invalid.

If you disagree, please reopen with a description of expected behavior based on the data this add-on has, as well as how this won't regress bug 558237.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Shouldn't it *not* be indexed, then?

https://preview.addons.mozilla.org/en-US/firefox/search?q=keychain+services+integration&cat=all finds it.

Comment 4

[Fred Wenzel [:wenzel]]

That makes sense. Kicking this over to Dave who probably needs to tweak the indexing query a little bit, to match the logic from bug 558237.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Aw, come on guys couldn't you at least give me a clean bug for this?

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

This is waiting on r?jbalogh, r?clouserw of:

http://github.com/davedash/zamboni/compare/master...celeryd

Comment 7

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commits/0a21890

Go through search thoroughly.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/search/?q=keymail+services+integration&cat=all&lver=any&atype=0&sort=&pid=1&pp=20&lup=&advanced=