566798 - Don't open restored tab automatically when TabCandy is opened.

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: Panorama, defect, P3)

Description

[dynamis (Tomoya ASAI)]

Step to reproduce
 1. open TabCandy with Ctrl+E (or pressing the tabCandy button)
 2. delete some tab(s)
 3. restore tab with Ctrl+Shift+T (or with menu)
 4. last deleted tab is opened in the "New Tabs" group's tabbar

Users cannot understand what happened exactly (at least I couldn't).
TabCandy should only restore the tab and keep TabCandy window open (not open restored tab automatically) to make user sure which tab is restored to which group.
Or, at least, we need some animation restoring the tab and then open it.

Also, I think restored tab should be in original TabCandy group, not "New Tabs" group at least restored just after the deletion.
That is, when user accidentally delete some tab(s) in the TabCandy window, he must want to restore the tab(s) in the original TabCandy group.

Comment 1

[Ian Gilman [:iangilman]]

Interesting point; if you close the tab while you're in the tab, restoring it should bring you back to being in the tab, but if you close that tab while in tab candy, perhaps restoring it should just reinstate it in Tab Candy without taking you there (at least if you're still in Tab Candy when you restore).

I'm not sure what the technical feasibility of this is; it may be beyond my current knowledge of Firefox internals. 

Assigning to Aza for design thoughts

Comment 2

[Aza Raskin [:aza]]

(In reply to comment #1)
+1 to Ian.

The design should be as follows.

(1) Re-opening tabs should be per zoomed-ingroup. That is if you close tab X while in group A and then move to group B and close tab Y, when you go back to group A and use "reopen tab" tab X should open.

(2) If you close a tab and re-open it while not in TabCandy, that tab appears where it last was in TabCandy. In the last group it was in. Because closing the last tab in a group removes the group (if it isn't named) and zooms out to TabCandy you cannot be zoomed into a group and use the undo close tab option. You'll have to do it from within the TabCandy interface.

(3) In TabCandy, using the re-open option re-opens the tabs exactly where they used to be. This happens across all groups.

Comment 3

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 4

[Hexadecima]

A couple of more notes to add to this:

1. Reopening tabs even while in normal browsing mode will kick them out into nowhere: close a tab while in it, press ctrl+shift+t, observe that the rest of your tabs have disappeared because you're no longer in the group.

2. Closing the loner tab mentioned above leaves you with your most recently-accessed tab, alone, even if it was in a tab group before. Entering and exiting the TabCandy interface fixes this.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

See also bug 587874.

Comment 6

[Aza Raskin [:aza]]

Adding this to beta 9 as a nice-to-have

Comment 7

[Kevin Hanes]

bugspam (moving b9 to b10)

Comment 8

[Kevin Hanes]

bugspam (removing b9)

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

This works for me. Dynamis, please let us know if you can still reproduce this issue.