DeCOMtaminate nsIStyleRule method signatures

RESOLVED FIXED

Status

()

defect
P4
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: craig.topper, Assigned: craig.topper)

Tracking

(Blocks 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
nsIStyleRule contains two NSIMETHOD methods that always return NS_OK and their callers don't check the return value anyway. The should be converted to void to remove the returns.

Patch coming soon.
(Assignee)

Comment 1

9 years ago
Attachment #446171 - Flags: review?(dbaron)
(Assignee)

Comment 2

9 years ago
Oops found an include dependency in nsSVGElement.h cause by the removal of some includes in one of the CSS header files. I'll submit a new patch to fix after review.
Comment on attachment 446171 [details] [diff] [review]
Patch to convert the two methods

r=dbaron with the include changes

However, note bug 239008 comment 29:  it's probably better to avoid making changes right now that do anything invasive to nsCSSStyleRule and related classes (though this one should be fine, and trivial to merge with).
Attachment #446171 - Flags: review?(dbaron) → review+
(Assignee)

Comment 4

9 years ago
Just needed to add a forward declaration.
Attachment #446171 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Pushed as: http://hg.mozilla.org/mozilla-central/rev/9a7be1835b53
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.