567030 - Orphan tab item bounds (used for pushAway and trenches) don't take title into account, resulting in title being covered up by other Items

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Tony Chung [:tchung]]

Attachment: Tab container focus screenshot

If you put the focus on the tab container (is that what you call it?), over the individual tab, it will cover up the page Title.  However, if you focus the individual tab over the tab container, then the title shows up transparent.

See screenshots

Repro:
1) install tab candy alpha
2) focus the tab container over the tab.  Verify it covers the title
3) now focus the tab over the tab container.  Verify the title appears underneath

Expected:
- Tab title should always appear and never covered.

Comment 1

[Tony Chung [:tchung]]

Attachment: Individual Tab focus screenshot

Comment 2

[Ian Gilman [:iangilman]]

I think the layering is fine, but the tab shouldn't be allowed to overlap its title over the group in the first place.

Comment 3

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".

Comment 4

[Michael Yoshitaka Erlewine [:mitcho]]

Note that this is a different, though related, issue to bug 567029.

Requesting blocking final+.

Comment 5

[Dietrich Ayala (:dietrich)]

Not going to hold the release for this. Would definitely take a safe patch though.

Comment 6

[Ian Gilman [:iangilman]]

Sean, hopefully your fix for bug 567029 will fix this as well.

Comment 7

[Sean Dunn]

From Ian's note on 567029: The root of the problem here is that a TabItem's bounds doesn't include its
title; this should be fixed. Note that doing so will make
TabItem.getBoundsWithTitle() obsolete.

Comment 8

[Aza Raskin [:aza]]

Adding this to beta9 as it is primarily visual.

Comment 9

[Kevin Hanes]

bugspam (moving b9 to b10)

Comment 10

[Kevin Hanes]

bugspam (removing b9)

Comment 11

[Michael Yoshitaka Erlewine [:mitcho]]

Sean, I'm going to mark this as punted, but if you get to this in beta 11, that would be great!

Comment 12

[Sean Dunn]

This should be taken care of with 567029, since the tab's bounds include the title with that bug.

Comment 13

[Ian Gilman [:iangilman]]

bug 567029 has landed; someone should verify that this has been fixed by it as well.

Comment 14

[Ian Gilman [:iangilman]]

bugspam: returning Sean's bugs to the pool

Comment 15

[Raymond Lee [:raymondlee]]

Tested on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0

This bug is no longer reproducible and it's fixed by the patch for bug 567029