567044 - Tapping in urlbar doesn't work after pressing Android menu button

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
1. Press the "Menu" key in Fennec for Android.  Site menu appears.
2. Tap in the urlbar.

Expected results: URL bar is focused, autocomplete popup and keyboard appear.
Actual results: URL bar is not focused, instead it disappears or scrolls away.

This patch fixes the above bug, and also adds a shortcut (Ctrl+M) to open the site menu.  This is mainly for ease of testing menu button behavior on desktop, but may also be useful on non-Android platforms like Maemo.  That part of the patch can be removed if it's not wanted, though.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 446430 [details] [diff] [review]
patch


>+    this._urlBar = document.getElementById("toolbar-container");

Instead of doing this, let's add "toolbar-container" to the Elements array:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/Util.js#261

call it "toolbarContainer" ?

Also update:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser.js#3486

>diff -r 3bddd1a6c503 chrome/content/browser.xul

>+    <key id="key_menu" key="m" modifiers="accel" command="cmd_menu"/>

I don't think we should do this yet

r+, but make a new patch for checkin

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

Updated based on review from Mark Finkle.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Hmm, I did find one oddity with this patch. If I open the site menu by clicking on the favicon, then click on the urlbar - the site menu is not closed. It stays open under the awesomebar. When you close the awesomebar without choosing a site, the site menu is still displayed.

I don't think I like that.

Madhava, any thoughts? Maybe we should force close the site menu when opening the awesomebar?

Comment 4

[Madhava Enros [:madhava]]

Yeah - the simplest conceptual model, I think, is that tapping outside the site menu dismisses it.  The URL bar is outside the site menu.

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: patch v3

Updated to hide the site menu (or any other popup) when focusing the urlbar.

To ensure these things will always happen at the same time, I also moved the call to showAutoComplete inside of showToolbar.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/f3c78175c3aa

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Android; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100524 Namoroka/3.7a4pre Fennec/2.0a1pre