567105 - Adblock Plus will not Update in New AOM

Status: RESOLVED DUPLICATE of bug 562930

(Toolkit :: Add-ons Manager, defect)

Description

[Gary King]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100520 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a5pre) Gecko/20100520 Minefield/3.7a5pre

Using today's build of Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100501 Minefield/3.7a5pre
Adblock Plus will not update properly. It appears to update but the extension itself is not listed in the list of extensions after a reboot. The Icons and functionality still seem to work. This was reported in bug 461973, which I cannot find. 

Reproducible: Always

Steps to Reproduce:
1. Install The latest Dev Build of Adblock Plus
2. Update extensions using the AOM
3. Adblock Plus will be gone after the reboot.
Actual Results:  
The extension is not listed in the add-ons list
I had to re install the extension

Expected Results:  
I would expect an update to Adblock Plus and not a deletion of the extension

Updated

Comment 1

[Dave Townsend [:mossop]]

Can you see if switching to say the themes and then back to extensions makes it appear in the list?

Comment 2

[Gary King]

No it does not.

Comment 3

[Dave Townsend [:mossop]]

Is there anything showing up in the error console when you try to view the add-ons manager?

Can you attach a copy of extensions.sqlite, extensions.log and extensions.ini from your profile folder (http://support.mozilla.com/en-US/kb/Profiles) to this bug report.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Gary, can you please specify which build you have installed in step 1? Is it one from this page: https://adblockplus.org/devbuilds/adblockplus/

I can't reproduce this reported issue so far.

Comment 5

[Gary King]

Attachment: extensions.ini

Comment 6

[Gary King]

Attachment: extension.log

Comment 7

[Gary King]

Attachment: extension.sqlite

all attachments wanted by Dave Townsend

Comment 8

[Gary King]

[url=https://adblockplus.org/devbuilds/adblockplus/adblockplus-1.3a.20100520.xpi]adblockplus-1.3a.20100520.xpi[/url]

ABP Build requested by Henrik Skupin

Comment 9

[Wladimir Palant]

I've seen this issue as well yesterday, confirming. The strange thing is that the Adblock Plus icon is still present in the toolbar after restart but not functional - according to add-on manager it shouldn't be there. After another restart it is gone altogether. Second installation attempt works then. This seems to be a recent regression, only a few days ago it worked fine.

Comment 10

[Dave Townsend [:mossop]]

Just realised that I think this is bug 562930

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #8)
> [url=https://adblockplus.org/devbuilds/adblockplus/adblockplus-1.3a.20100520.xpi]adblockplus-1.3a.20100520.xpi[/url]
> 
> ABP Build requested by Henrik Skupin

This is the latest version of the available dev builds. So what do you mean with step 2 in your comment 0?

Comment 12

[Paul [pwd]]

WFM, just updated manually.

Comment 13

[Wladimir Palant]

Dave, I don't think it is a duplicate - I better reopen.

My steps to reproduce:

1. Install https://adblockplus.org/devbuilds/adblockplus/adblockplus-1.2.0+.2010050102.xpi
2. Go to Add-on Manager, right-click Adblock Plus entry and select "Find updates".
3. Click "Restart Firefox" button when it appears.

From Error Console (20100520 Minefield build on Windows 7):

LOG addons.xpi: Processing install of {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d} in app-profile

Error: ERROR addons.xpi: Failed to install staged add-on {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d} in app-profile: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.remove]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///c:/Program%20Files%20(x86)/firefox/modules/XPIProvider.jsm :: DirInstallLocation_installAddon :: line 4736"  data: no]

Warning: WARN addons.xpi: Ignoring file: C:\Users\Wladimir\AppData\Roaming\Mozilla\Firefox\Profiles\hup8wgu1.test\extensions\staged\{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}.json

LOG addons.xpi: Add-on {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d} modified in app-profile

Warning: WARN addons.xpi: Add-on is invalid: ReferenceError: dir is not defined

Error: ERROR addons.xpi: Error processing file changes: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.remove]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///c:/Program%20Files%20(x86)/firefox/modules/XPIProvider.jsm :: DirInstallLocation_uninstallAddon :: line 4763"  data: no]

Later comes the extension which explains why Adblock Plus icon is dysfunctional:

Error: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: file:///.../extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D/modules/Utils.jsm :: anonymous :: line 186"  data: no]
Source File: file:///.../extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D/modules/Utils.jsm
Line: 186

The extension directory contains only an chrome/adblockplus.jar file, all other files have been removed. But apparently only after Adblock Plus was initialized - the error message itself comes from a module that was removed.

Comment 14

[Dave Townsend [:mossop]]

Why do you think this isn't the same as bug 562930? Seems to have exactly the same symptoms.

Looks like something locked the jar file stopping us from removing it so this is probably a Windows only issue

Comment 15

[Wladimir Palant]

Clarification for the last sentence: the modules load during "profile-after-change" notification, meaning that add-on manager attempts to remove the extension after that notification. One of the modules will load a chrome URL from adblockplus.jar which should explain why the file is locked and cannot be removed.

Bug 562930 was reported a while ago - this issue seems to be a recent regression however. Also, it is talking about Adblock Plus 1.2 which has a very different initialization sequence (ok, I should check whether I can reproduce with the stable release as well). So I better say: I'm not sure it is a duplicate.

Comment 16

[Wladimir Palant]

Oh well, I guess it is a duplicate after all - I have exactly the same thing with Adblock Plus 1.1.3 to 1.2 update (compatibility checking disabled). Different error from Adblock Plus code which suddenly fails to instantiate its component but other than that all the same. extensions.ini still contains an entry for Adblock Plus like Gary's (ten active extensions in my profile as well).

Comment 17

[Gary King]

Paul, if you have the Latest Dev Build installed and then hit the update addons button the extension will vanish