567184 - A bootstrap add-on with a target app version less than the current app version is enabled when installed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Found while writing the tests for bug 546595.

I was able to install a bootstrap add-on and it was enabled with an install.rdf as follows

<?xml version="1.0"?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
  xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:id>[e-mail]</em:id>
    <em:version>2.0</em:version>
    <em:bootstrap>true</em:bootstrap>
    <em:name>test1</em:name>
    <em:description>Test Description</em:description>
    <em:targetApplication>
      <Description>
        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
        <em:minVersion>undefined</em:minVersion>
        <em:maxVersion>undefined</em:maxVersion>
      </Description>
    </em:targetApplication>
  </Description>
</RDF>

The bootstrap.js just stubbed the required functions

There was nothing in the error console

Comment 1

[Robert Strong (they/them - no direct email)]

I think bug 567175 might fix this

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch with test

Simple fix with a simple test

Comment 3

[Robert Strong (they/them - no direct email)]

No need for a litmus test for this specific issue... the xpcshell test suffices for this specific bug.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 447944 [details] [diff] [review]
patch with test

Good catch, thanks

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/7e51fa360a01

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100530 Minefield/3.7a5pre ID:20100530040319

The one remaining issue I have filed as bug 569149.