567703 - Integrate electrolysis (e10s) into Jetpack SDK

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

We should figure out a strategy for integrating electrolysis (e10s) into the Jetpack SDK, including which parts of the APIs are going to live in the chrome process vs. separate addon processes, how to give addons access to content DOM objects (window, document, etc.), and what changes will need to be made to the existing and forthcoming APIs to render them e10s-compatible.

Atul says he can take this on and work with the e10s team to work through these issues, so assigning this bug to him.

Comment 1

[Benjamin Smedberg]

Attachment: "working" multi-process jetpack .xpi

This is the hacked-up XPI we did tonight as a PoC.

* The main module is configured as remote-main.js instead of main.js
* That hardcodes some paths to launch the remote process and set up message receivers for it, and load the "real" jetpack main into it.
* remote-core.js is basically "hacky cuddlefish for the jetpack process", and for now I just hard-coded module impls for widget and xhr.

Comment 2

[Atul Varma [:atul]]

Thanks Benjamin! I've created a jetpack package that does roughly the same thing, which warner, irakli and I used as a springboard for discussion on Friday:

http://github.com/toolness/oop-jetpack-sdk-poc

I'll write up a summary of what we discussed and post it as either a blog post or a forum post to the google group, I think.

Comment 3

[Atul Varma [:atul]]

Latest update on this is here:

http://github.com/toolness/jetpack-e10s/#readme

Comment 4

[Atul Varma [:atul]]

I'm now working on a patch to get the changes into the SDK:

http://github.com/toolness/jetpack-sdk/tree/e10s

Comment 5

[Atul Varma [:atul]]

Note that Brian Warner and I are currently pair-programming on the above branch.

Comment 6

[Atul Varma [:atul]]

Attachment: Final patch

Comment 7

[Atul Varma [:atul]]

Comment on attachment 487062 [details] [diff] [review]
Final patch

This patch is taken from all the changesets in this github branch:

  http://github.com/toolness/jetpack-sdk/tree/e10s

From the branch's inception, up to and including commit 4c768aa5e004e3efb45b1608559be69e969702fc.

The code was all pair programmed by warner and I; I'd take the driver's seat when we were changing code that warner knew best, and vice versa.

Some of the code was written solo by me, but we synchronously code reviewed it together.

Comment 8

[Brian Warner [:warner :bwarner]]

Comment on attachment 487062 [details] [diff] [review]
Final patch

awesome!

Comment 9

[Brian Warner [:warner :bwarner]]

landed: http://github.com/mozilla/addon-sdk/commit/7ed39b2a99effc09b71209e97ea7825023aff351

Comment 10

[Dietrich Ayala (:dietrich)]

WOO! congrats on getting this landed!

Comment 11

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".