930164 - [e10] Jetpack Add-on SDK support for e10s

Status: RESOLVED DUPLICATE of bug 1004745

(Add-on SDK Graveyard :: General, defect, P4)

Description

[Chris Peterson [:cpeterson]]

bsmedberg says: "It is certainly a work item to make the Jetpack implementation e10s-compatible. I believe the following high-level (stable) APIs are affected; they already use the content-script pattern for touching content, so in general we just need to make sure that content scripts work, and then hook up tabs and widget."

* context-menu
* page-mod
* page-worker
* panel
* selection
* tabs
* widget

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(cc'ing Mossop & Irakli)

It is true that by design the Add-on SDK's apis should work with e10s. There was a lot of work done in 2011 to achieve this goal. Large parts of the SDK codebase have changed since then so I suspect we will need to fix things up in various points. Bugs found in testing should block this bug.

I guess the first question is, with an e10s build so the SDK tests pass?

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

P4, because it's a tracking bug.

Comment 3

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Important note to people starting to look at this: due to the new apis being added with Australis in Firefox 29, the widget api is now deprecated.

Comment 4

[Chris Peterson [:cpeterson]]

Zombie: is this bug a duplicate of a different tracking bug you are using to track your Jetpack work?

Comment 5

[Tomislav Jovanovic :zombie]

you could say this is a dup of bug 1004745, i filed that one because i wanted my own tracking bug, without presumptions of setting someone else's agenda.

or i guess this could depend on that other one..

Comment 6

[Steve Sobel]

is there a timeline for e10s fix for jetpack addons?

because of the rather long lead time for AMO to approve addons (I'm a reviewer myself, I know it's a lot of work! not trying to complain, just addressing the reality of the situation), it would be really helpful to have an idea of when a fix might be forthcoming and how soon I need to work ahead of that to test, potentially get a new version submitted, etc.

Comment 7

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Steve Sobel from comment #6)
> is there a timeline for e10s fix for jetpack addons?
> 
> because of the rather long lead time for AMO to approve addons (I'm a
> reviewer myself, I know it's a lot of work! not trying to complain, just
> addressing the reality of the situation), it would be really helpful to have
> an idea of when a fix might be forthcoming and how soon I need to work ahead
> of that to test, potentially get a new version submitted, etc.

This is the remaining queue of issues. A key issue is the context menu, which will likely involve a compatibility break.

I currently don't expect e10s will get out of nightly until Gecko 37 or 38, and we hope to have Jetpack issues resolved prior to that point.

HTH

Comment 8

[Tomislav Jovanovic :zombie]

(In reply to Steve Sobel from comment #6)
> is there a timeline for e10s fix for jetpack addons?

there is still not a timeline for e10s as a whole. we hope to get "most things mostly working" in the next month, enough for e10s to be turned on by default in Nightly 36 (but probably without riding the train to Aurora right away).


> an idea of when a fix might be forthcoming and how soon I need to work ahead
> of that to test, potentially get a new version submitted, etc.

except the context-menu issue Jeff mentioned above (which we still don't have the complete answer for), there shouldn't be any changes required for most addons, and thus no need for most authors to re-submit to AMO..

Comment 9

[Dave Townsend [:mossop]]

I don't think there is any point having both these bugs open.