567799 - Thunderbird's message filters are disabled after overlaying Tools menu using onpopupshowing

Status: RESOLVED INVALID

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mario Alvarado [:marioalv]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 ( .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4

For Babylon Dictionary Word Search 1.2 addon, I overlay Thunderbird's Tools menu.  I use onpopupshowing property to overlay the Tools menu: <menupopup id="taskPopup" onpopupshowing="BabylonWordSearch.overwriteBabylonToolsMenu();">

The problem is, if I use the onpopupshowing property in the overlay, the message filters are disabled in Tools menu.  
Even if I use onpopupshowing="" (no function is called), the message filters are still disabled.

I played a little bit with the menupopup properties, and noticed that if I use the onpopupshown="BabylonWordSearch.overwriteBabylonToolsMenu();" property to overlay the Tools menu, the message filters are enabled.

Reproducible: Always

Steps to Reproduce:
1. Install Babylon Dictionary Word Search 1.2 on Thunderbird
2. Go to Tools menu
3. Message filters are disabled
Actual Results:  
Thunderbird message filters are disabled after installing Babylon Dictionary Word Search

Expected Results:  
Thunderbird message filters should be enabled after installing Babylon Dictionary Word Search

This is the code I'm using in the extension
  <menupopup id="taskPopup"
             onpopupshowing="BabylonWordSearch.overwriteBabylonToolsMenu();">
    <menuitem id="babylon-word-search-tools-panel" ...>
  </menupopup>

For the message filters to be enabled, I need to use the property onpopupshown instead of onpopupshowing.

Comment 1

[Wayne Mery (:wsmwk)]

Mario,
Do you still see this issue when using version 5 or 6 (due out a week)?
- If problem was caused by addon, please set resolution to INVALID.
- If you no longer see the problem, please set status to RESOLVED, and set resolution to WORKSFORME.
- If you still see the problem, please provide updated details, and any additional steps needed to reproduce the problem.

Comment 2

[Alice0775 White]

Attachment: test xpi onpopupshowing version

Confirmed on
http://hg.mozilla.org/mozilla-central/rev/145c98d55ae1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110814 Thunderbird/8.0a1

Comment 3

[Alice0775 White]

Attachment: onpopupshown version

Comment 4

[Ludovic Hirlimann [:Usul]]

Alice any chances for you to come up with a patch ?

Comment 5

[Alice0775 White]

(In reply to Ludovic Hirlimann [:Usul] from comment #4)
> Alice any chances for you to come up with a patch ?

aha, the behavior is by design.

because, 
See http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#1596
The popup has onpopupshowing property.
However, the code in comment #0 and attachment 552981 [details] will overwrite onpopupshowing property. 
so, document.commandDispatcher.updateCommands('create-menu-tasks') of the original never execute.

Change status to INVALID