567989 - vCard setting "Prefers to receive messages formatted as" empty if not set to "Unknown"

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Victor Engmark]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.3) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100423 Lightning/1.0b1 Thunderbird/3.0.4

When this is set to anything other than "Unknown", upon re-entering the dialog it is set to an empty string, and the selection list is squashed vertically.

Reproducible: Always

Steps to Reproduce:
1. Create an account
2. In the account settings, click "Edit Card..."
3. Change the setting "Prefers to receive messages formatted as" to "Plain Text" or "HTML"
4. Click "OK"
5. Click "Edit Card..."
Actual Results:  
The "Prefers to receive messages formatted as" value is empty.

Expected Results:  
The "Prefers to receive messages formatted as" value should be what I selected before.

To make sure it was not set to something which could not be displayed properly, I did the following:
1. Selected "Plain Text"
2. Clicked OK
3. Clicked Edit Card...
4. Clicked the now-empty field
5. Waited for a second
6. Clicked the field again to close the selection
7. Pressed the down arrow

The selection was now "Unknown", not "HTML" as you would expect for a display issue.

Comment 1

[Victor Engmark]

Attachment: Screenshot

Comment 2

[Victor Engmark]

Example vCard from prefs.js:
user_pref("mail.identity.id1.escapedVCard", "begin%3Avcard%0D%0Afn%3AJohn%20Doe%0D%0An%3ADoe%3BJohn%0D%0Aemail%3Binternet%3Ajohn.doe%40example.com%0D%0Ax-mozilla-html%3AFALSE%0D%0Aversion%3A2.1%0D%0Aend%3Avcard%0D%0A%0D%0A");

So the property is set correctly, but the state is not reflected correctly in the interface.

Comment 3

[Javi Rueda :javirid]

Tested on latest trunk on OS X and it worked as expected. When closing the Edit Card... dialog box, however, it was a warning that some field MUST NOT be empty. Filling it with some random text worked as it should be.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 567989 - vCard setting "Prefers to receive messages formatted" was broken. r=darktrojan

Some broken stuff in here...
We might want to rip this out entirely, but as long as we have it, let's make it work.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 567989 - clean up textLength remains from de-XBL. r=darktrojan

Depends on D116509

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d934c4d3b072
vCard setting "Prefers to receive messages formatted" was broken. r=darktrojan
https://hg.mozilla.org/comm-central/rev/2d06b4ec62f5
clean up textLength remains from de-XBL. r=darktrojan