> Robert Kaiser 2010-05-06 04:10:20 PDT
>>>>+ this.msgHeader = aMsgHeader;
>> Removed. It was introduced in the first version of the Thunderbird patch
>> without any comment on the reason.
> Just as a side note, should a Thunderbird bug be raised on that and possibly
> any other things review improved here over their code?
> David :Bienvenu 2010-05-06 07:51:59 PDT
> sure, that would be nice, thx for thinking of that.
>> firstname.lastname@example.org 2010-05-03 16:26:27 PDT
>> (From update of attachment 442350 [details] [diff] [review] [details])
>>>+ 8 // 1 << (kMsgNotificationMSN - 1)
>> Typo: MDN
>>>+ this.msgHeader = aMsgHeader;
> Removed. It was introduced in the first version of the Thunderbird patch
> without any comment on the reason.
>>>+ if (!msgFlags)
>> What does this achieve?
> No idea. Removed.
>>>+ list-style-image: url("chrome://global/skin/icons/Warning.png");
>> Surely the old dialog would have used a Question or possibly Information image?
> The old dialog used Question, switching to Question.png.
Created attachment 594268 [details] [diff] [review]
Fix the nits, and also i made it work correctly with the non-standard Return-Receipt-To. (Strangely enough i had a mail from an outlook user, in one mail its the standard header, in the next the non-standard, go figure...)
The notification bar images were broken in many ways :/
Also i don't think the mdn bar needs to be hidden for deleted imap messages if they are showing. It probably made sense when it was a dialog...
Comment on attachment 594268 [details] [diff] [review]
Seems good, and the tests still pass, so r=me.