568447 - Fix nits discovered while porting Bug 151244 to SeaMonkey and make mdn work for non-standard header too

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Philip Chee]

>  Robert Kaiser      2010-05-06 04:10:20 PDT
> 
>>>>+    this.msgHeader = aMsgHeader;
>>> Unused?
>> Removed. It was introduced in the first version of the Thunderbird patch
>> without any comment on the reason.
> 
> Just as a side note, should a Thunderbird bug be raised on that and possibly
> any other things review improved here over their code?
> 
> David :Bienvenu 2010-05-06 07:51:59 PDT
> 
> sure, that would be nice, thx for thinking of that.

From https://bugzilla.mozilla.org/show_bug.cgi?id=539066#c12

>>  [e-mail]      2010-05-03 16:26:27 PDT
>> 
>> (From update of attachment 442350 [details] [diff] [review] [details])
>>>+                    8  // 1 << (kMsgNotificationMSN - 1)
>> Typo: MDN
> Fixed.
> 
>>>+    this.msgHeader = aMsgHeader;
>> Unused?
> Removed. It was introduced in the first version of the Thunderbird patch
> without any comment on the reason.
> 
>>>+  if (!msgFlags)
>>>+    return;
>> What does this achieve?
> No idea. Removed.
> 
>>>+  list-style-image: url("chrome://global/skin/icons/Warning.png");
>> Surely the old dialog would have used a Question or possibly Information image?
> 
> The old dialog used Question, switching to Question.png.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Fix the nits, and also i made it work correctly with the non-standard Return-Receipt-To. (Strangely enough i had a mail from an outlook user, in one mail its the standard header, in the next the non-standard, go figure...)

The notification bar images were broken in many ways :/

Also i don't think the mdn bar needs to be hidden for deleted imap messages if they are showing. It probably made sense when it was a dialog...

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 594268 [details] [diff] [review]
proposed fix

Seems good, and the tests still pass, so r=me.

Thanks,
Blake.

Comment 3

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/comm-central/rev/052af292b83e
->FIXED