Closed Bug 568643 Opened 14 years ago Closed 14 years ago

discover and log iframe network requests

Categories

(DevTools :: General, defect, P2)

x86
All
defect

Tracking

(blocking2.0 betaN+)

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: ddahl, Assigned: pcwalton)

References

Details

Attachments

(1 file)

We are not getting iframe load events in the console right now as the iframe's loadGroup will need to be QI'd to discover if it has a parent loadgroup. (i think i understand this correctly)
No longer blocks: 534398
Blocks: 529086
Priority: -- → P2
Summary: check loadGroup parent to discover and log iframe network loads → discover and log iframe network requests
Whiteboard: [kd4b4]
Assignee: ddahl → jviereck
Status: NEW → ASSIGNED
Depends on: 568634
This bug is part of improving the logging of networking messages in the WebConsole. Requesting blocking status for this bug.
blocking2.0: --- → ?
blocking2.0: ? → betaN+
Whiteboard: [kd4b4] → [kd4b5]
This seems to be fixed with the patch from bug 587573. Will add some tests for iFrame logging anyway.
Depends on: 587573
Whiteboard: [kd4b5] → [kd4b6]
Attached patch Patch v1.0Splinter Review
Adds some unit tests for logging of iFrame requests + a little bit of code to make activating of an HUD work well with iFrames/Frames.

Can someone else take over this bug? The patch looks complicated when reading it but after it's applied, it should be simple to understand what's going on.
Attachment #471119 - Flags: feedback?(ddahl)
Assignee: julian.viereck → pwalton
I'll just point out that bug 593003 is about logging of iframe requests as well. If this patch has more than just tests, it would be good to make sure that these two bugs are in sync.
Whiteboard: [kd4b6]
Will wait on bug 593003, which is further along in the review process.
Depends on: 593003
This is now fixed as far as I know. If any more issues are found re. logging of network requests in iframes, anyone is free to reopen, but I'm closing for now.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #471119 - Flags: feedback?(ddahl)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: