593003 - WebConsole: iFrames can get associated to wrong HUD

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Julian Viereck]

Attachment: how-this-could-be-solved-patch

It seems like iFrames get associated to the WebConsole that is opened in the current selected tab and not the WebConsole of the parentWindow the iFrames is added to.

Testcase:

Open the WebConsole on http://www.heise.de/ and on another page. Reload heise.de and switch over to the other tab with opened WebConsole. You will see network logging of iFrames of the heise.de page in the false/other WebConsole.

Patch:

The patch enclosed checks if the initialized window is an iFrames. If that's try the top most parent window is queried and the hudId is looked up by looking up the hudid associated with the parentWindow.

Comment 1

[Kevin Dangoor]

Reprioritizing bugs. You can filter the mail on the word TEABAGS.

Comment 2

[Mihai Sucan [:msucan]]

Attachment: proposed patch

Proposed fix. The previous patch was correct in its intent on how to fix the issue, but there were some bugs which caused the entire WebConsole to fail during windowInitialize() - I think Julian did not have sufficient time to test the patch.

In this patch I've corrected the fix for the windowInitializer method, and I have also included an automatic test for the problem.

Comment 3

[Mihai Sucan [:msucan]]

Comment on attachment 472615 [details] [diff] [review]
proposed patch

Thank you David for the feedback+!

Asking for review from Shawn.

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 472615 [details] [diff] [review]
proposed patch

nit: use the public domain license header in the tests please per http://www.mozilla.org/MPL/license-policy.html

r=sdwilsh

Comment 5

[Mihai Sucan [:msucan]]

Attachment: [checked-in] updated patch

Updated patch per reviewer comment. Thanks Shawn!

Comment 6

[Kevin Dangoor]

Comment on attachment 473143 [details] [diff] [review]
[checked-in] updated patch

carried forward r+. approval requested to land this improvement to the console's handling of iframes.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 473143 [details] [diff] [review]
[checked-in] updated patch

http://hg.mozilla.org/mozilla-central/rev/a7d83f9da547

Comment 8

[Mihai Sucan [:msucan]]

Marking the bug as fixed.