[e10s] remote History Set Title for URI

RESOLVED FIXED

Status

()

Core
IPC
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

unspecified
x86
Windows CE
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(fennec2.0a1+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
Created attachment 448069 [details] [diff] [review]
patch v.1
Assignee: nobody → dougt
Attachment #448069 - Flags: review?(sdwilsh)
(Assignee)

Updated

8 years ago
Attachment #448069 - Flags: review?(sdwilsh) → review?(jones.chris.g)
Comment on attachment 448069 [details] [diff] [review]
patch v.1

>diff --git a/toolkit/components/places/src/History.cpp b/toolkit/components/places/src/History.cpp
>--- a/toolkit/components/places/src/History.cpp
>+++ b/toolkit/components/places/src/History.cpp
>@@ -1162,18 +1162,28 @@ History::UnregisterVisitedCallback(nsIUR
> 
>   return NS_OK;
> }
> 
> NS_IMETHODIMP
> History::SetURITitle(nsIURI* aURI, const nsString& aTitle)
> {
>   NS_PRECONDITION(aURI, "Must pass a non-null URI!");
>+#ifdef MOZ_IPC
>+  if (XRE_GetProcessType() == GeckoProcessType_Content) {
>+    mozilla::dom::ContentProcessChild * cpc = 

Inconsistent pointer formatting (|Foo*| above).

>+      mozilla::dom::ContentProcessChild::GetSingleton();
>+    NS_ASSERTION(cpc, "Content Protocol is NULL!");
>+    (void) cpc->SendSetURITitle(IPC::URI(aURI), aTitle);
>+    return NS_OK;
>+  } 
>+#endif /* MOZ_IPC */
> 
>   nsNavHistory* history = nsNavHistory::GetHistoryService();
>+

Accidental newline?
Attachment #448069 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/projects/electrolysis/rev/87122ab4c9b2
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

8 years ago
This was backed out a few days ago because the required places patches were backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 457429 [details] [diff] [review]
patch v1.1

just the patch Doug pushed to tryserver, that applies.
Attachment #448069 - Attachment is obsolete: true
Depends on: 556400

Updated

8 years ago
tracking-fennec: --- → 2.0+

Updated

8 years ago
tracking-fennec: 2.0+ → 2.0a1+
(Assignee)

Updated

8 years ago
Blocks: 516521

Comment 6

8 years ago
Could we add the relevant places patches as dependencies please?  I'm having trouble figuring out what all needs to patched in what order.
OS: Linux → Windows CE
(Assignee)

Comment 7

8 years ago
Comment on attachment 457429 [details] [diff] [review]
patch v1.1

moving review forward.
Attachment #457429 - Flags: review+
(Assignee)

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/2900644a71c6
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED

Comment 9

7 years ago
Comment on attachment 457429 [details] [diff] [review]
patch v1.1

>@@ -1259,6 +1259,16 @@ History::SetURITitle(nsIURI* aURI, const nsAString& aTitle)
>     return NS_OK;
>   }
> 
>+#ifdef MOZ_IPC
>+  if (XRE_GetProcessType() == GeckoProcessType_Content) {
>+    mozilla::dom::ContentProcessChild* cpc = 
>+      mozilla::dom::ContentProcessChild::GetSingleton();
>+    NS_ASSERTION(cpc, "Content Protocol is NULL!");
>+    (void)cpc->SendSetURITitle(IPC::URI(aURI), nsDependentString(aTitle));
aTitle isn't guaranteed to be null-terminated. Did you mean PromiseFlatString?
(Assignee)

Comment 10

7 years ago
no please file a new bug, and lets track it there.  Thanks for noticing this issue!

Updated

7 years ago
Depends on: 624742
You need to log in before you can comment on or make changes to this bug.