568925 - [e10s] remote History Set Title for URI

Status: RESOLVED FIXED

(Core :: IPC, defect)

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 448069 [details] [diff] [review]
patch v.1

>diff --git a/toolkit/components/places/src/History.cpp b/toolkit/components/places/src/History.cpp
>--- a/toolkit/components/places/src/History.cpp
>+++ b/toolkit/components/places/src/History.cpp
>@@ -1162,18 +1162,28 @@ History::UnregisterVisitedCallback(nsIUR
> 
>   return NS_OK;
> }
> 
> NS_IMETHODIMP
> History::SetURITitle(nsIURI* aURI, const nsString& aTitle)
> {
>   NS_PRECONDITION(aURI, "Must pass a non-null URI!");
>+#ifdef MOZ_IPC
>+  if (XRE_GetProcessType() == GeckoProcessType_Content) {
>+    mozilla::dom::ContentProcessChild * cpc = 

Inconsistent pointer formatting (|Foo*| above).

>+      mozilla::dom::ContentProcessChild::GetSingleton();
>+    NS_ASSERTION(cpc, "Content Protocol is NULL!");
>+    (void) cpc->SendSetURITitle(IPC::URI(aURI), aTitle);
>+    return NS_OK;
>+  } 
>+#endif /* MOZ_IPC */
> 
>   nsNavHistory* history = nsNavHistory::GetHistoryService();
>+

Accidental newline?

Comment 3

[Doug Turner (:dougt)]

http://hg.mozilla.org/projects/electrolysis/rev/87122ab4c9b2

Comment 4

[Doug Turner (:dougt)]

This was backed out a few days ago because the required places patches were backed out.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.1

just the patch Doug pushed to tryserver, that applies.

Comment 6

[Josh Matthews [:jdm]]

Could we add the relevant places patches as dependencies please?  I'm having trouble figuring out what all needs to patched in what order.

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 457429 [details] [diff] [review]
patch v1.1

moving review forward.

Comment 8

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/2900644a71c6

Comment 9

[[e-mail]]

Comment on attachment 457429 [details] [diff] [review]
patch v1.1

>@@ -1259,6 +1259,16 @@ History::SetURITitle(nsIURI* aURI, const nsAString& aTitle)
>     return NS_OK;
>   }
> 
>+#ifdef MOZ_IPC
>+  if (XRE_GetProcessType() == GeckoProcessType_Content) {
>+    mozilla::dom::ContentProcessChild* cpc = 
>+      mozilla::dom::ContentProcessChild::GetSingleton();
>+    NS_ASSERTION(cpc, "Content Protocol is NULL!");
>+    (void)cpc->SendSetURITitle(IPC::URI(aURI), nsDependentString(aTitle));
aTitle isn't guaranteed to be null-terminated. Did you mean PromiseFlatString?

Comment 10

[Doug Turner (:dougt)]

no please file a new bug, and lets track it there.  Thanks for noticing this issue!