Closed Bug 569355 Opened 14 years ago Closed 14 years ago

source code reorg, redux

Categories

(Cloud Services :: General, defect)

Product:
Cloud Services
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mconnor, Assigned: Mardak)

References

(
URL
)

Details

Attachments

(2 files, 2 obsolete files)

v1.1
95.41 KB, patch
mconnor
: review+
Details | Diff | Splinter Review
more moves v1.1
12.62 KB, patch
Details | Diff | Splinter Review 
Goals:

* Separate crypto and sync modules cleanly from UI pieces
* Split Fennec/Firefox UI/strings/etc
* Make it possible to hg convert a subset into something we can push into mozilla-central at controlled code drop points.
Target Milestone: --- → 1.4
Flags: blocking-fx-sync1.4+
Assignee: mconnor → edilee
Attached patch v1 (obsolete) — — Splinter Review 
Main oddness is strings loaded from util.js into Str but most aren't actually used by the service. Some files are duplicated like sync-32x32.png as it's used for the add-on icon as well as other app-specific UI bits.
Attachment #450229 - Flags: review?(mconnor)
Attached patch v1.1 — — Splinter Review 
test: build
-	$(MAKE) -k -C tests/unit
+	$(MAKE) -k -C services/sync/tests/unit
Attachment #450229 - Attachment is obsolete: true
Attachment #450241 - Flags: review?(mconnor)
Attachment #450229 - Flags: review?(mconnor)
Attachment #450241 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/services/fx-sync/rev/f5a64d0ecc66
Split the code structure to service/{crypto,sync} and ui/{fennec,firefox}. Update the top level makefile to build the addon staging directory to merge various parts of directories.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 571902
Blocks: 573632
Attached patch more moves v1 (obsolete) — — Splinter Review 

        Attachment #452898 -
        Flags: review?(mconnor)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        more moves v1.1
        — 
          — Splinter Review
      

    


  
Fennec doesn't sync prefs so no need to copy there.

        Attachment #452898 -
        Attachment is obsolete: true

        Attachment #452910 -
        Flags: review?(mconnor)

        Attachment #452898 -
        Flags: review?(mconnor)

    
  

        Attachment #452910 -
        Flags: review?(mconnor)

    
  
Blocks: 573691

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: