source code reorg, redux

RESOLVED FIXED in 1.4

Status

Cloud Services
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mconnor, Assigned: Mardak)

Tracking

unspecified
Points:
---
Dependency tree / graph
Bug Flags:
blocking-fx-sync1.4 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Goals:

* Separate crypto and sync modules cleanly from UI pieces
* Split Fennec/Firefox UI/strings/etc
* Make it possible to hg convert a subset into something we can push into mozilla-central at controlled code drop points.
(Reporter)

Updated

8 years ago
Target Milestone: --- → 1.4
(Assignee)

Updated

8 years ago
Duplicate of this bug: 570572
(Assignee)

Updated

8 years ago
Flags: blocking-fx-sync1.4+
(Assignee)

Updated

8 years ago
Assignee: mconnor → edilee
(Assignee)

Comment 2

8 years ago
Created attachment 450229 [details] [diff] [review]
v1

Main oddness is strings loaded from util.js into Str but most aren't actually used by the service. Some files are duplicated like sync-32x32.png as it's used for the add-on icon as well as other app-specific UI bits.
Attachment #450229 - Flags: review?(mconnor)
(Assignee)

Comment 3

8 years ago
Created attachment 450241 [details] [diff] [review]
v1.1

 test: build
-	$(MAKE) -k -C tests/unit
+	$(MAKE) -k -C services/sync/tests/unit
Attachment #450229 - Attachment is obsolete: true
Attachment #450241 - Flags: review?(mconnor)
Attachment #450229 - Flags: review?(mconnor)
(Reporter)

Updated

8 years ago
Attachment #450241 - Flags: review?(mconnor) → review+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/services/fx-sync/rev/f5a64d0ecc66
Split the code structure to service/{crypto,sync} and ui/{fennec,firefox}. Update the top level makefile to build the addon staging directory to merge various parts of directories.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Blocks: 571902
(Assignee)

Updated

8 years ago
Blocks: 573632
(Assignee)

Comment 5

8 years ago
Created attachment 452898 [details] [diff] [review]
more moves v1
Attachment #452898 - Flags: review?(mconnor)
(Assignee)

Comment 6

8 years ago
Created attachment 452910 [details] [diff] [review]
more moves v1.1

Fennec doesn't sync prefs so no need to copy there.
Attachment #452898 - Attachment is obsolete: true
Attachment #452910 - Flags: review?(mconnor)
Attachment #452898 - Flags: review?(mconnor)
(Assignee)

Updated

8 years ago
Attachment #452910 - Flags: review?(mconnor)
(Assignee)

Updated

8 years ago
Blocks: 573691
You need to log in before you can comment on or make changes to this bug.