569508 - Tryserver emails should come with headers for grouping/threading

Status: RESOLVED DUPLICATE of bug 621681

(Release Engineering :: General, enhancement, P4)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Now that tryserver sends out dozens of emails per push, it is somewhat difficult to manage the emails.  It would be nice if tryserver emails were set up to get grouped/threaded in popular email clients.  I think the way this works is you set the Message-ID or In-Reply-To headers (http://superuser.com/questions/61159/avoid-gmail-threading).  If that understanding is correct, I think you could set the In-Reply-To header to <[e-mail]> or something similar to accomplish the desired effect.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

We should already be setting headers like this

In-Reply-To: <tryserver-%revision>
References: <tryserver-%revision>

Could you verify that ?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I get those, but they don't appear to have useful content.  From an hour ago.

Delivered-To: [e-mail]
Received: by 10.229.102.8 with SMTP id e8cs254782qco;
        Tue, 1 Jun 2010 17:42:10 -0700 (PDT)
Received: by 10.141.91.16 with SMTP id t16mr5529435rvl.128.1275439329362;
        Tue, 01 Jun 2010 17:42:09 -0700 (PDT)
Return-Path: <[e-mail]>
Received: from dm-mail03.mozilla.org (dm-mail03.mozilla.org [63.245.208.213])
        by mx.google.com with ESMTP id k14si13260778rvh.44.2010.06.01.17.42.08;
        Tue, 01 Jun 2010 17:42:09 -0700 (PDT)
Received-SPF: pass (google.com: domain of [e-mail] designates 63.245.208.213 as permitted sender) client-ip=63.245.208.213;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of [e-mail] designates 63.245.208.213 as permitted sender) smtp.mail=[e-mail]
Received: from production-master02.build.mozilla.org (production-master02.build.mozilla.org [10.2.71.7])
	by dm-mail03.mozilla.org (Postfix) with SMTP id A0F544AED9A
	for <[e-mail]>; Tue,  1 Jun 2010 17:42:08 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain
Date: Tue, 01 Jun 2010 17:42:04 -0700
Subject: Try Server: success on OS X 10.5.2 tryserver debug test mochitests-3/5
From: [e-mail]
References: <tryserver-unknown>
In-Reply-To: <tryserver-unknown>
CC: 
To: [e-mail]
Message-Id: <[e-mail]>

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

nthomas points out the "build has completed" emails do get an id
Delivered-To: [e-mail]
Received: by 10.229.102.8 with SMTP id e8cs256296qco;
        Tue, 1 Jun 2010 18:14:25 -0700 (PDT)
Received: by 10.115.113.22 with SMTP id q22mr6002209wam.62.1275441264345;
        Tue, 01 Jun 2010 18:14:24 -0700 (PDT)
Return-Path: <[e-mail]>
Received: from dm-mail03.mozilla.org (dm-mail03.mozilla.org [63.245.208.213])
        by mx.google.com with ESMTP id 6si2408713pzk.113.2010.06.01.18.14.24;
        Tue, 01 Jun 2010 18:14:24 -0700 (PDT)
Received-SPF: pass (google.com: domain of [e-mail] designates 63.245.208.213 as permitted sender) client-ip=63.245.208.213;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of [e-mail] designates 63.245.208.213 as permitted sender) smtp.mail=[e-mail]
Received: from production-master02.build.mozilla.org (production-master02.build.mozilla.org [10.2.71.7])
	by dm-mail03.mozilla.org (Postfix) with SMTP id 95E834AEE8F
	for <[e-mail]>; Tue,  1 Jun 2010 18:14:23 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain
Date: Tue, 01 Jun 2010 18:14:17 -0700
Subject: Try Server: success on OS X 10.5.2 tryserver build
From: [e-mail]
References: <tryserver-e8c990927eb1>
In-Reply-To: <tryserver-e8c990927eb1>
CC: 
To: [e-mail]
Message-Id: <[e-mail]>

They still don't get threaded in gmail though.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

The tests vs builds difference (unknown vs actual revision) is from using the 'got_revision' property when setting extraHeaders on the emailer, near
  http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l436
That property doesn't exist on the tests, which have 'revision' instead. The builds have a sensible value for 'got_revision' but 'revision' is None. Fun!

Comment 5

[Chris AtLee [:catlee]]

The only way to thread in gmail that I've found is to have the subjects match...but then we can't put any meaningful information in the subject.

Comment 6

[Armen [:armenzg]]

I have checked this for Gmail and for Thunderbird.
As soon as the subject changes the "In-Reply-To" and "References" fields are not part of the email which is what I believe enables the threading.


MIME-Version: 1.0
Received: by 10.216.180.196 with HTTP; Tue, 3 Aug 2010 07:25:50 -0700 (PDT)
In-Reply-To: <AANLkTik3wEEb6u=[e-mail]>
References: <AANLkTik3wEEb6u=[e-mail]>
Date: Tue, 3 Aug 2010 10:25:50 -0400
Delivered-To: [e-mail]
Message-ID: <AANLkTikvzYtfs_Us==UCOPQKkBiJ6QGZW8_F1a=[e-mail]>
Subject: Re: hey

MIME-Version: 1.0
Received: by 10.216.180.196 with HTTP; Tue, 3 Aug 2010 07:24:01 -0700 (PDT)
Date: Tue, 3 Aug 2010 10:24:01 -0400
Delivered-To: [e-mail]
Message-ID: <AANLkTik3wEEb6u=[e-mail]>
Subject: hey

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Duping this to the "enhance threading" bug since we do have headers they just need to be improved in order to be more useful on some clients that aren't helped by the current threading. One bug will do for tracking.