Closed
Bug 569836
Opened 14 years ago
Closed 14 years ago
Build fails on Fedora Core 13
Categories
(Firefox Build System :: General, defect)
Tracking
(status1.9.2 .9-fixed)
RESOLVED
FIXED
mozilla1.9.3a5
Tracking | Status | |
---|---|---|
status1.9.2 | --- | .9-fixed |
People
(Reporter: bjacob, Assigned: bjacob)
References
Details
Attachments
(1 file)
511 bytes,
patch
|
ted
:
review+
christian
:
approval1.9.2.9+
dveditz
:
approval1.9.1.19-
|
Details | Diff | Splinter Review |
Building firefox on Fedora Core 13 fails with this error: mozilla-central/toolkit/crashreporter/google-breakpad/src/common/linux/file_id.cc:132: error: ‘fstat’ was not declared in this scope A fix is attached, which as far as I understand is OK since this is linux-specific anyway. This seems to be an upstream bug, already reported to upstream: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/edc32dca4f7120c1 Note to fedora users stumbling on this: in addition to this fix, you will also need to make sure to have the glibc-static package installed to get firefox to build on F13.
Assignee | ||
Comment 1•14 years ago
|
||
thanks to cjones for the idea --- although it's trivial, I let the above link discourage me from trying it!
Attachment #449020 -
Flags: review?(jones.chris.g)
Comment 3•14 years ago
|
||
FYI, Breakpad upstream is here: http://code.google.com/p/google-breakpad/
Comment 4•14 years ago
|
||
Comment on attachment 449020 [details] [diff] [review] Fix build on fedora 13 I'll land this upstream for you as well.
Attachment #449020 -
Flags: review?(jones.chris.g) → review+
Updated•14 years ago
|
Assignee: nobody → bjacob
Comment 5•14 years ago
|
||
Upstream: http://code.google.com/p/google-breakpad/source/detail?r=605
Assignee | ||
Comment 6•14 years ago
|
||
Thank! Note: I don't have commit rights to mozilla-central yet, so can you please check in there too.
Keywords: checkin-needed
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b80d5c5faccf
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.3a5
Comment 9•14 years ago
|
||
Comment on attachment 449020 [details] [diff] [review] Fix build on fedora 13 Thunderbird 3.1.x (current) and Thunderbird 3.2 (next) both are using mozilla-1.9.2; it would be great to be able to build Thunderbird on Fedora 13 sans patched mozilla-1.9.2.
Attachment #449020 -
Flags: approval1.9.2.9?
Comment 10•14 years ago
|
||
Comment on attachment 449020 [details] [diff] [review] Fix build on fedora 13 a=LegNeato for 1.9.2.9. Please land soon, as code freeze is this Thursday @ 11:59 pm PST.
Attachment #449020 -
Flags: approval1.9.2.9? → approval1.9.2.9+
Comment 11•14 years ago
|
||
pushed to mozilla-1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/cd8dde452873 Thank you for the approval.
status1.9.2:
--- → .9-fixed
Comment 12•13 years ago
|
||
Comment on attachment 449020 [details] [diff] [review] Fix build on fedora 13 I've hit this on 32bit Fedora 14 but not 64bit. I've been moving away from Centos5 builders and it would be nice to still be able to build 1.9.1 on my newer Fedora instances.
Attachment #449020 -
Flags: approval1.9.1.18?
Comment 13•13 years ago
|
||
Comment on attachment 449020 [details] [diff] [review] Fix build on fedora 13 Approved for 1.9.1.18, a=dveditz for release-drivers
Attachment #449020 -
Flags: approval1.9.1.18? → approval1.9.1.18+
Comment 14•13 years ago
|
||
Comment on attachment 449020 [details] [diff] [review] Fix build on fedora 13 Review of attachment 449020 [details] [diff] [review]: We've built and almost shipped 1.9.1.19 so this didn't make it. Don't want it landing now
Attachment #449020 -
Flags: approval1.9.1.19+ → approval1.9.1.19-
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•