569836 - Build fails on Fedora Core 13

Status: RESOLVED FIXED

Description

[Benoit Jacob [:bjacob] (mostly away)]

Building firefox on Fedora Core 13 fails with this error:

mozilla-central/toolkit/crashreporter/google-breakpad/src/common/linux/file_id.cc:132: error: ‘fstat’ was not declared in this scope

A fix is attached, which as far as I understand is OK since this is linux-specific anyway.

This seems to be an upstream bug, already reported to upstream:
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/edc32dca4f7120c1

Note to fedora users stumbling on this: in addition to this fix, you will also need to make sure to have the glibc-static package installed to get firefox to build on F13.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Created attachment 449020 [details] [diff] [review]
Fix build on fedora 13

thanks to cjones for the idea --- although it's trivial, I let the above link discourage me from trying it!

Comment 3

[Ted Mielczarek [:ted.mielczarek]]

FYI, Breakpad upstream is here: http://code.google.com/p/google-breakpad/

Comment 4

[Ted Mielczarek [:ted.mielczarek]]

Comment on attachment 449020 [details] [diff] [review]
Fix build on fedora 13

I'll land this upstream for you as well.

Comment 5

[Ted Mielczarek [:ted.mielczarek]]

Upstream:
http://code.google.com/p/google-breakpad/source/detail?r=605

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Thank! Note: I don't have commit rights to mozilla-central yet, so can you please check in there too.

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/mozilla-central/rev/b80d5c5faccf

Comment 9

[Andrew Sutherland [:asuth]]

Comment on attachment 449020 [details] [diff] [review]
Fix build on fedora 13

Thunderbird 3.1.x (current) and Thunderbird 3.2 (next) both are using mozilla-1.9.2; it would be great to be able to build Thunderbird on Fedora 13 sans patched mozilla-1.9.2.

Comment 10

[christian]

Comment on attachment 449020 [details] [diff] [review]
Fix build on fedora 13

a=LegNeato for 1.9.2.9. Please land soon, as code freeze is this Thursday @ 11:59 pm PST.

Comment 11

[Andrew Sutherland [:asuth]]

pushed to mozilla-1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/cd8dde452873

Thank you for the approval.

Comment 12

[Bob Clary [:bc:] (pto 1/5)]

Comment on attachment 449020 [details] [diff] [review]
Fix build on fedora 13

I've hit this on 32bit Fedora 14 but not 64bit. I've been moving away from Centos5 builders and it would be nice to still be able to build 1.9.1 on my newer Fedora instances.

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 449020 [details] [diff] [review]
Fix build on fedora 13

Approved for 1.9.1.18, a=dveditz for release-drivers

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 449020 [details] [diff] [review]
Fix build on fedora 13

Review of attachment 449020 [details] [diff] [review]:

We've built and almost shipped 1.9.1.19 so this didn't make it. Don't want it landing now