Open Bug 570131 Opened 10 years ago Updated 8 years ago

Taskbar icon doesn't glow on completed download if DM is closed

Categories

(Toolkit :: Downloads API, defect, major)

x86
Windows 7
defect
Not set
major

Tracking

()

People

(Reporter: jmjjeffery, Unassigned)

References

Details

Regression range:
20100604043300 01a82f7a4e70 bad

20100604040314 6dbc5341b490 ok

Looks like this checkin broke it:
https://bugzilla.mozilla.org/show_bug.cgi?id=560462
Wait, that regression is not right - 
20100604040314 6dbc5341b490  is bad, and same cset as today's nightly.
No longer blocks: 560462
Range:
20100603193229 6a2a086f9e78  bad
 
20100603153410 4a076422aa26  ok

Several failed builds between those two cset's - not sure what patch broke it.
Component: Password Manager → Download Manager
QA Contact: password.manager → download.manager
Blocks: 524811
(In reply to comment #2)
> Range:
> 20100603193229 6a2a086f9e78  bad
> 
> 20100603153410 4a076422aa26  ok
> 
> Several failed builds between those two cset's - not sure what patch broke it.

For sure, I know I tested build 4a076422aa26 and saw it working.
This works for me with today's nightly (built from 6dbc5341b490). Note that the icon will only glow if the download manager is not the current active window.
Can you re-verify with this observation?
(In reply to comment #6)
> This works for me with today's nightly (built from 6dbc5341b490). Note that the
> icon will only glow if the download manager is not the current active window.
> Can you re-verify with this observation?


Interesting, I can tomorrow.. at work now 

@Jonas, 
Download any file with Win7 that has the Iconic Taskbar. Once the download is complelte it should turn 'orange', during the down there is a green progress bar on the Icon, and a scrolling bar on the Icon during VirusScan.
(In reply to comment #6)
> This works for me with today's nightly (built from 6dbc5341b490). Note that the
> icon will only glow if the download manager is not the current active window.
> Can you re-verify with this observation?
So orange glow will only show up if I have opened two Firefox windows and download manager is downloading a file in the second one which isn't active?
Because my download manager is disabled (not showed) and it ain't working.
(In reply to comment #8)
> So orange glow will only show up if I have opened two Firefox windows and
> download manager is downloading a file in the second one which isn't active?
> Because my download manager is disabled (not showed) and it ain't working.

No, you need just one Firefox window opened, + the download manager window. The Download Manager just must not be the active window (the glowing icon is a call for window focus/attention, and if the download manager is already active it won't display the glow)
And when DM never show up, then what?
Do you mean it never appeared, or you closed it before the download finished? I don't know what are the situations for the DM not showing up at all. Still, if there are situations like that then this alert won't serve for that purpose.

If the DM was closed, the info about finished downloads will be given on the notification bar that pops up. I don't think we should glow the icon for the main window because it would be ambiguous what that means since there's no indication on the main window about finished downloads.
It never appeared. I'm using only Superbar for download progress.
(In reply to comment #6)
> This works for me with today's nightly (built from 6dbc5341b490). Note that the
> icon will only glow if the download manager is not the current active window.
> Can you re-verify with this observation?

I think this is accurate.  I just tried it and now WFM.
So if one selects from Tools-Options-General and unchecks the box to 'show the download manager', the Animated Icon is not expected to work?  

If that's the current case, then the bug to enable it is incomplete.

I need to re-test, but I'm pretty sure that the TaskBar Icon does show the download progress even if the DM is showing in the active-tab, thus follows the logic that the 'Completed download' should also notify in the TaskBar Icon. 

It will be tomorrow afternoon before I can test further with the above notes, comments.
(In reply to comment #14)
> So if one selects from Tools-Options-General and unchecks the box to 'show the
> download manager', the Animated Icon is not expected to work?  
> 
> If that's the current case, then the bug to enable it is incomplete.
> 
> I need to re-test, but I'm pretty sure that the TaskBar Icon does show the
> download progress even if the DM is showing in the active-tab, thus follows the
> logic that the 'Completed download' should also notify in the TaskBar Icon. 
> 
> It will be tomorrow afternoon before I can test further with the above notes,
> comments.

If I don't show the download manager, as noted here, then the main window you are downloading from shows the green progress bar.  The orange glow doesn't occur if the DM is not open or is it already active.  Looks like the orange glow patch didn't also apply to main windows.
That's right, the download progress is displayed even if DM is closed, but the glowing won't. I agree that it's strange behavior, but we couldn't show it even if we wanted (unless your Firefox window was unactive).
This is more of a UX thing. I wonder how this fits on the current plans to display download info on the main window.

(I'm morphing the bug because it's not a regression)
Keywords: regression
Summary: Download complete glowing icon not working → Taskbar icon doesn't glow on completed download if DM is closed
Ok, it sounds like this is not a regression at all then (much less due to bug 564591 or bug 564863).

Un-cc'ing myself. If it does turn out that this is a regression after all, and one likely due to one of those bugs, please cc me again.

(Also, for what it's worth, it might be better to close this bug an open a new one on the UX issue. Morphing bugs tend to be very confusing to follow and often stay confused to the bitter end. But I'll leave that decision up to you guys.)
You need to log in before you can comment on or make changes to this bug.