570257 - warning "comparison between signed and unsigned integer expressions" at WebGLContextValidate.cpp:64

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Daniel Holbert [:dholbert]]

content/canvas/src/ was recently build-warning-free, but this new warning appeared recently (treated as error because I was building with WARNINGS_AS_ERRORS):
{
/builds/slave/tryserver-linux-debug/build/content/canvas/src/WebGLContextValidate.cpp: In member function ‘PRBool mozilla::WebGLContext::ValidateBuffers(PRUint32)’:
/builds/slave/tryserver-linux-debug/build/content/canvas/src/WebGLContextValidate.cpp:64: error: comparison between signed and unsigned integer expressions
}
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1275693673.1275694686.23724.gz

Regression from bug 569984 -- looks like we just need a signed-->unsigned cast.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

The fix...
 - adds a WebGLuint() cast for the comparison
 - changes %d to %u in the LogMessage() call, on the next line (since GLName is an unsigned value)

Comment 3

[Daniel Holbert [:dholbert]]

landed: http://hg.mozilla.org/mozilla-central/rev/d6ca75b6d4ba