570902 - Remove ifdefs relating to MOZILLA_1_9_2 from Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Justin Wood (:Callek)]

Mark told me on IRC we are ready for this for the rest of c-c.

Comment 1

[Justin Wood (:Callek)]

Attachment: remove storage-backport

The upcoming patch obsoletes storage-backport. Instead if show a patch that removes it all, I'll just attach the hg addremove output from its MQ changeset.

Comment 2

[Justin Wood (:Callek)]

I'm not sure what we are meant to do with: http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMessengerOSXIntegration.mm So would appreciate someone else taking over that file work.

Comment 3

[Justin Wood (:Callek)]

Attachment: kill the ifdef

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 450049 [details]
remove storage-backport

This seems right and the changes in the patch seem right too.

(Per http://hg.mozilla.org/comm-central/rev/4be99c0f6036 I only touched 2 files outside of storage-backport, and your patch removes those bits again.)

Comment 5

[Mark Banner (:standard8)]

Attachment: Kill the ifdefs in nsMessengerOSXIntegration

This seems to be the right way to get rid of the extra code in nsMessengerOSXIntegration. Requesting review from Makoto as he put in most of the ifdefs in the first place ;-)

Comment 6

[Mark Banner (:standard8)]

Both patches checked in:
http://hg.mozilla.org/comm-central/rev/2b23b224f246
http://hg.mozilla.org/comm-central/rev/7d85c2f48e77

Comment 7

[Justin Wood (:Callek)]

Landed the storage-backport removal http://hg.mozilla.org/comm-central/rev/115997fdba57 though I botched the commit message on that one.