Closed
Bug 571143
Opened 14 years ago
Closed 14 years ago
Support Windows 64 bit builds in TinderboxPushlog
Categories
(Tree Management Graveyard :: TBPL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
3.84 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
I also tweaked the matrix styling a bit so that more stuff fits on the screen.
Attachment #450260 -
Flags: review?(mstange)
Assignee | ||
Updated•14 years ago
|
Summary: Support Windows 64 bit builds → Support Windows 64 bit builds in TinderboxPushlog
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•14 years ago
|
||
See <http://ehsanakhgari.org/tinderboxpushlog/index.html> if you need an example of how things with my patch look like.
Comment 2•14 years ago
|
||
Comment on attachment 450260 [details] [diff] [review] Patch (v1) Thanks for picking up my slack! Just one thing: Can you increase the width of ".results .os" to 65 or 70px (and likewise the margin-left of .osresults)? Not sure how this will look on different platforms, but on Mac it's almost overlapping, so I think some pixels more are in order.
Attachment #450260 -
Flags: review?(mstange) → review+
Updated•14 years ago
|
Blocks: support-win64
Comment 4•14 years ago
|
||
This does make "Windows 64" overlap the results section too for me. Perhaps just "Win64" instead for brevity rather than increasing space used?
Comment 5•14 years ago
|
||
Yeah, maybe that's better. I think I did the same for "OSX 64".
Comment 6•14 years ago
|
||
Any chance this can land soon? The Win64 builds are ending up in the 'Win' row, which is a bit confusing.
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/449302485960 (In reply to comment #4) > This does make "Windows 64" overlap the results section too for me. Perhaps > just "Win64" instead for brevity rather than increasing space used? I decided to do that, because Tinderbox is down right now, and I couldn't test the proposed CSS change. (In reply to comment #2) > Just one thing: Can you increase the width of ".results .os" to 65 or 70px (and > likewise the margin-left of .osresults)? Not sure how this will look on > different platforms, but on Mac it's almost overlapping, so I think some pixels > more are in order. Hmm, I think a better way to fix the overlap could be changing the width of matrix columns. However, I'd personally prefer there to be a deviding line between them and having them as close to each other as possible. That would make the best use of space, without causing confusion. Right? (In reply to comment #5) > Yeah, maybe that's better. I think I did the same for "OSX 64". Nope, you didn't. :-) I was about to do that when landing, but maybe that's not useful now, because we do get talos results for OSX64, and therefore the width is really used.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 8•14 years ago
|
||
(In reply to comment #7) > http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/449302485960 Deployed. > (In reply to comment #4) > Hmm, I think a better way to fix the overlap could be changing the width of > matrix columns. Hmm? I was thinking of the labels in front of the results in the push list, not of the matrix.
Assignee | ||
Comment 9•14 years ago
|
||
Ah, then I totally didn't understand what you meant the first time! http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/1aec6b70a744
Updated•14 years ago
|
Blocks: support-L64
Updated•14 years ago
|
No longer blocks: support-L64
Comment 10•14 years ago
|
||
Probably a good idea to hold off on deploying this until bug 570882 is fixed, since the Win64 builds are permared and hidden right now.
Depends on: 570882
Comment 11•14 years ago
|
||
It won't hurt to land it but we won't be able to verify it until I unhide the builds.
Updated•10 years ago
|
Product: Webtools → Tree Management
Updated•9 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•