571151 - WARNING: -[NSObject(NSKeyValueCoding) takeValue:forKey:] is deprecated

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

10.6.3 Console noted:
6/10/10 9:09:01 AM	Camino[2572]	*** WARNING: -[NSObject(NSKeyValueCoding) takeValue:forKey:] is deprecated. It will be removed in a future release and should no longer be used.

(I'm not clear what triggered it; I don't remember seeing it before. According to my history, I was loading elpais.com at that moment).

sauron: I think it's http://mxr.mozilla.org/camino/source/src/bookmarks/BookmarkViewController.mm#1476

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix?

According to http://developer.apple.com/mac/library/documentation/cocoa/reference/foundation/Protocols/NSKeyValueCoding_Protocol/DeprecationAppendix/AppendixADeprecatedAPI.html#//apple_ref/occ/instm/NSObject/takeValue:forKey: it's been deprecated since 10.3, too (big surprise; our 10.2-era table and outline views using deprecated calls :P ).

Even better, the fix should be s/take/set/, which means I can attach a patch!

Comment 2

[Stuart Morgan]

Comment on attachment 450279 [details] [diff] [review]
Fix?

sr=smorgan

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/f4815e4678bb

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Er, and CVS trunk; I forgot this applied there.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on CAMINO_2_0_BRANCH in advance of 2.0.6.  (See bug 571152 comment 6 for why.)