571152 - Method selectedRowEnumerator in class BookmarkOutlineView is deprecated

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

console noted:
6/9/10 2:23:58 PM	Camino[1751]	*** WARNING: Method selectedRowEnumerator in class BookmarkOutlineView is deprecated. It will be removed in a future release and should no longer be used.

(editing a bookmark in the BM manager)

http://mxr.mozilla.org/camino/search?string=selectedRowEnumerator&tree=camino

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Also deprecated since 10.3: http://developer.apple.com/mac/library/documentation/cocoa/reference/ApplicationKit/Classes/NSTableView_Class/DeprecationAppendix/AppendixADeprecatedAPI.html#//apple_ref/occ/instm/NSTableView/selectedRowEnumerator

Replacement is NSIndexSet selectedRowIndexes; it's not quite as straightforward to replace as bug 571151 (in particular, we call nextObject on our enumerators, and I don't see a direct replacement for that in NSIndexSet), so I'm not going to be able to attach a patch for this bug ;)

Comment 2

[Stuart Morgan]

Attachment: fix

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 450925 [details] [diff] [review]
fix

+        [mBookmarksOutlineView collapseItem:doomedItem];

does collapsing upset the list of indices such that they're no longer valid afterwards?

sr=pink

Comment 4

[Stuart Morgan]

Yes, that's why there's the funny double-loop with the break after any collapse happens. Not terribly efficient, but I was trying to update with minimal changes.

Comment 5

[Stuart Morgan]

Landed http://hg.mozilla.org/camino/rev/f1315c2a2799

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This was causing conflicts landing bug 569258 on the branch, and since this and bug 571151 have been deprecated since 10.3, and 10.7 is next summer, Stuart said we could take them on branch.

Landed on CAMINO_2_0_BRANCH in advance of 2.0.6.