571443 - "get_fix_stack" step should not use obsolete fix-macosx-stack.pl (got "Bad output from otool" on Mac64)

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Jesse Ruderman]

http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#842

When fix_stack_using_bpsyms.py is ready (bug 570287), get_fix_stack should be changed to use it instead of fix-%s-stack.pl.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276230745.1276232213.506.gz&fulltext=1

If this red is frequent, maybe we could temporarily skip the stack fixer, and use "cp" instead.  (Don't use fix_macosx_stack.py, it's busted on 64-bit too.)

Comment 1

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276231393.1276234811.9229.gz

Comment 2

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276279576.1276282424.11697.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276261486.1276262943.1853.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276250431.1276251918.798.gz

Comment 3

[Jonathan Kew [:jfkthame]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276283178.1276286434.27398.gz

Comment 4

[Jonathan Kew [:jfkthame]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276283990.1276289527.6405.gz

Comment 5

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276285342.1276291255.12903.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276292711.1276299347.20070.gz

Comment 6

[Jesse Ruderman]

I wonder why this suddenly became a frequent red.

Comment 7

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276498632.1276500141.32588.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276503277.1276505543.28507.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276521255.1276522735.12318.gz

Comment 8

[Drew Willcoxon :adw]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276531049.1276536264.23811.gz

Comment 9

[Drew Willcoxon :adw]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276538946.1276540387.12399.gz

Comment 10

[(no longer active)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276881495.1276886191.1049.gz

Comment 11

[Henri Sivonen (:hsivonen)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1276930760.1276934132.2610.gz&fulltext=1

Comment 12

[(no longer active)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1277127768.1277130645.28965.gz

Comment 13

[Chris AtLee [:catlee]]

Nothing for RelEng to do here until bug 570287 is fixed, correct?

Comment 14

[Jesse Ruderman]

You could skip stack-fixing entirely for now (see comment 0).

Comment 15

[Chris AtLee [:catlee]]

(In reply to comment #14)
> You could skip stack-fixing entirely for now (see comment 0).

Just on OSX 10.6 64-bit?

Comment 16

[Jesse Ruderman]

Yeah, that sounds reasonable.

Comment 17

[Chris AtLee [:catlee]]

Attachment: copy sdleak.tree.raw to sdleak.tree [Checkin: Comment 21]

I can't really test this because the alive test keeps failing prior to this....but it looks like it'll work!

Comment 18

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 452828 [details] [diff] [review]
copy sdleak.tree.raw to sdleak.tree
[Checkin: Comment 21]

r+. Bustage at compare_sdleak_tree may be entertaining, assuming we ever get that far.

Comment 19

[Chris AtLee [:catlee]]

dbaron, any thoughts on using sdleak.tree.raw in place of sdleak.tree here?

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is the difference between the two the lack of fix-macosx-stack being run on them?  If fix-macosx-stack worked, that would make the output significantly less useful, but not entirely useless.  But given that it doesn't, sounds fine.

Comment 21

[Serge Gautherie (:sgautherie)]

Comment on attachment 452828 [details] [diff] [review]
copy sdleak.tree.raw to sdleak.tree
[Checkin: Comment 21]

buildbot-0.8.0 branch:
http://hg.mozilla.org/build/buildbotcustom/rev/3dec35ce1e44

Comment 22

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> When fix_stack_using_bpsyms.py is ready (bug 570287), get_fix_stack should be
> changed to use it instead of fix-%s-stack.pl.
> 
> (Don't use fix_macosx_stack.py, it's busted on 64-bit too.)

Bug 570287 has been fixed 5 months ago.
Can fix_stack_using_bpsyms.py be used now?

Comment 23

[Chris Cooper [:coop] (he/him)]

(In reply to Serge Gautherie (:sgautherie) from comment #22) 
> Bug 570287 has been fixed 5 months ago.
> Can fix_stack_using_bpsyms.py be used now?

Given that this has sat for a further 18 months now (sorry about that), is this still needed/wanted?

Comment 24

[Jesse Ruderman]

Probably.  But I'm not seeing any output from diffbloatdump.pl in the logs I look at, so it's hard to be sure.

https://tbpl.mozilla.org/php/getParsedLog.php?id=12484772&tree=Firefox

Comment 25

[Chris Cooper [:coop] (he/him)]

Attachment: Use fix_stack_using_bpsyms.py script instead of fix-%s-stack.pl

Comment 26

[Chris Cooper [:coop] (he/him)]

Comment on attachment 632292 [details] [diff] [review]
Use fix_stack_using_bpsyms.py script instead of fix-%s-stack.pl

https://hg.mozilla.org/build/buildbotcustom/rev/b20f1a16297b

Comment 27

[Chris AtLee [:catlee]]

deployed to production

Comment 28

[Chris Cooper [:coop] (he/him)]

Comment on attachment 632292 [details] [diff] [review]
Use fix_stack_using_bpsyms.py script instead of fix-%s-stack.pl

https://hg.mozilla.org/build/buildbotcustom/rev/b20f1a16297b