571537 - Flash 10.1 doesn't accept text input with Cocoa events

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benoit Girard (:BenWa)]

STR:
1. Run the following game: http://www.kongregate.com/games/IriySoft/cursed-treasure-dont-touch-my-gems.
2. After the pre-loader, hit play.
3. In main menu select 'New game'.
4. Input name.

Flash is not responding to keyboard input.

Comment 1

[Benoit Girard (:BenWa)]

This bug isn't caused by the OOPP changes but it will impact the OOPP beta so I'm adding it to the tracker bug.

Comment 2

[aravindm]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a6pre) Gecko/20100613 Minefield/3.7a6pre
Able to reproduce. When selecting "New Game" from main menu and trying to input Name, flash is not responding to the keyboard input.

Comment 3

[aravindm]

Build worked : 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090826 Minefield/3.7a1pre

http://hg.mozilla.org/mozilla-central/rev/485a319ce5e6

Build broken : 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090827 Minefield/3.7a1pre

http://hg.mozilla.org/mozilla-central/rev/72d25f49cbcb

Pushlog : 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=485a319ce5e6&tochange=72d25f49cbcb

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Pushlog : 
> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=485a319ce5e6&tochange=72d25f49cbcb

Lots of stuff in there, but bug 435041 would be my first guess.

Comment 5

[Benoit Girard (:BenWa)]

The events appear to be implemented correctly part of bug 435041. We are investigating if Flash is responding to cocoa key events correctly or not.

Comment 6

[Marcia Knous [:marcia]]

Unfortunately this affects some Facebook games such as Pet Society.

Comment 7

[d]

I've seen this in a number of cases recently, too. Surely this must be a final-version blocker?

Comment 9

[d.a.]

I believe this bug also happens on YouTube. You can't pause any video with the space bar. If you play the video in full screen keyboard input works however. Could be related to bug 557225 as I didn't see this before that one landed.

Comment 10

[Benoit Girard (:BenWa)]

The problem is not the same as bug 557225. The reason input handling does not work is because Flash is not responding to cocoa key event delivered via the NPAPI (Plug-in API).

When entering full-screen mode flash creates a full-screen windows and does it own event handling.

Comment 11

[Damon Sicore (:damons)]

We should fix this sooner rather than later as this causes people to switch browsers without hesitation.

Comment 13

[juan becerra [:juanb]]

Go to grooveshark.com and try to login. At least a couple of people have pinged me about this, and they report they can't enter text in other sites (that use Flash). I will re-request blocking2.0, so it gets triaged and, maybe, fixed earlier than final.

Comment 14

[Josh Aas]

This is caused by a bug in Flash 10.1, not Gecko, we're working on a resolution.

Comment 16

[Damon Sicore (:damons)]

Josh, do you think we have everything we need to actually get to some sort of resolution?  Do we need help from Adobe?

Comment 17

[Josh Aas]

I've been talking to Adobe about this, I'll have an update soon.

Comment 19

[Aakash Desai [:aakashd]]

We're seeing this quite a bit from our beta users via Input:

http://input.mozilla.com/en-US/search/?q=flash+text+input&product=firefox

Comment 21

[Justin Dolske [:Dolske]]

What's the plan for resolving this? ISTR it being deemed a bug with Flash 10.1, but I think this is also clearly a Fx4 final release blocker -- we can't ship if Flash doesn't work, no matter whose fault the root bug may be.

Comment 22

[Benjamin Smedberg]

Moving this back to Core so the blocking flag is visible and correct.

Comment 23

[Paul Betlem]

I'm checking on an update from the Flash Player side.

Comment 24

[Michelle Sintov]

We have fixed this Flash Player bug internally and the fixed version of the player will be released within the next couple weeks of August. Thanks for bringing this issue to our attention.

Comment 25

[Josh Aas]

Can we just make the blocking flag available for plugin bugs? I agree that we want this to be blocking but categorizing it incorrectly in order to make that happen isn't ideal.

Comment 26

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #25)
> Can we just make the blocking flag available for plugin bugs? I agree that we
> want this to be blocking but categorizing it incorrectly in order to make that
> happen isn't ideal.

Bug 584632.

Comment 27

[Josh Aas]

I think the just-release Flash 10.1.82.76 fixes this. If someone else can confirm we can close this out.

Comment 28

[Benoit Girard (:BenWa)]

Running 10.1.82.76, the original STR I posted are working.

Comment 30

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=12784 added to Litmus.