571662 - Toolbar background should be darker

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Peter Henkel [:Terepin]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100611 Minefield/3.7a6pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100611 Minefield/3.7a6pre

1. (Tabs At Bottom) Toolbars background should be slightly transparent with use of Aero Glass.
2. (Tabs At Bottom) Toolbars background is missing gradient in upper part.
3. (Tabs At Bottom and Tabs On Top) Toolbars background should have light blue color instead of grey.

Reproducible: Always

Comment 1

[Peter Henkel [:Terepin]]

Attachment: Current background for tabs At Bottom

Comment 2

[Peter Henkel [:Terepin]]

Attachment: Current background for Tabs On Top

Comment 3

[Peter Henkel [:Terepin]]

4. (Tabs At Bottom) Increase space between Bookmarks bar and Navigation bar (current nav buttons are touching Bookmarks bar).
5. (Tabs On Top) Increase space between Navigation bar and page content/Tab bar (current nav buttons aren't centered. I don't know if this adjusment is neccesary if Bookmarks bar is showed; hard to tell from mockups).

Comment 4

[[not reading bugmail]]

The mockups looks like there are two types of gradient colors.  I prefer the darker one labeled: Large Button mode with Bookmarks Bar, the current brighter one we have is too hard on the eyes and distracting from the UX.

Comment 5

[Peter Henkel [:Terepin]]

Attachment: Toolbars background (Tabs On Top)

6. (Tabs On Top) Currently, the background is square. It should have curved corners. In fact, background share same style as tabs, so even shadows intruduced in Bug 570278 should be applied to background too and if I'm not mistaken, around page content as well. Also, it should be perfectly alligned with page content.

Comment 6

[ronin.achilles]

For this, the color defined in the line

+%define customToolbarColor rgb(227,237,246)

in Bug 568037 should be changed to a darker color like rgb(190,205,220).

Comment 7

[Peter Henkel [:Terepin]]

According to this: https://wiki.mozilla.org/Firefox/Projects/New_Theme/Timeline#.5BWindows.5D_Beta_1_Theme_Requirements I'm requesting blocking beta1+.

Comment 8

[Peter Henkel [:Terepin]]

(In reply to comment #0)
> 3. (Tabs At Bottom and Tabs On Top) Toolbars background should have light blue
> color instead of grey.
Correction:
3. (Tabs At Bottom and Tabs On Top) Toolbars background should have more blueish color.
Sorry for that, Dão.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

this might be a dupe to an existing bug, shorlander and dao would know.

Comment 10

[Peter Henkel [:Terepin]]

I've filled this bug very soon after toolbars have landed. There is no such bug to my knowledge.

Comment 11

[imradyurrad]

Attachment: Toolbars background (Tabs On Bottom)

Comment 12

[Peter Henkel [:Terepin]]

Requesting to block beta4+.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Shorlander: do you think this should block release?

Comment 14

[Stephen Horlander [:shorlander]]

(In reply to comment #13)
> Shorlander: do you think this should block release?

Yes.

Comment 15

[Dão Gottwald [:dao]]

Morphing, please file individual bugs on any remaining issues.

Comment 16

[Dão Gottwald [:dao]]

Attachment: patch

Comment 17

[Peter Henkel [:Terepin]]

Can I see screenshot of patch, please?

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 469802 [details] [diff] [review]
patch

rs=me

Comment 19

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/6ce9c793cda3

Comment 20

[Peter Henkel [:Terepin]]

Looks fantastic!
I'll fill up bugs for remaining issues.
Dao, are there things that can be grouped into one bug, or I shall create bugs for each one issue?

Comment 21

[Dão Gottwald [:dao]]

Separate bugs are generally preferable. If the fix for one issue also fixes another one, bug dependencies can express this.

Comment 22

[Peter Henkel [:Terepin]]

(In reply to comment #5)
> Created attachment 450919 [details]
> Toolbars background (Tabs On Top)
> 
> 6. (Tabs On Top) Currently, the background is square. It should have curved
> corners. In fact, background share same style as tabs, so even shadows
> intruduced in Bug 570278 should be applied to background too and if I'm not
> mistaken, around page content as well. Also, it should be perfectly alligned
> with page content.

Dao, isn't this being covered in another bug?

Comment 23

[Dão Gottwald [:dao]]

(In reply to comment #22)
> (In reply to comment #5)
> > Created attachment 450919 [details] [details]
> > Toolbars background (Tabs On Top)
> > 
> > 6. (Tabs On Top) Currently, the background is square. It should have curved
> > corners. In fact, background share same style as tabs, so even shadows
> > intruduced in Bug 570278 should be applied to background too and if I'm not
> > mistaken, around page content as well. Also, it should be perfectly alligned
> > with page content.
> 
> Dao, isn't this being covered in another bug?

bug 589259

Comment 24

[Peter Henkel [:Terepin]]

Actually, I had on my mind only the shadow. And found the bug for it: bug 588764.
Well, this bug fixed, I filled bugs for more issues reported in this bug and the last will be fixed in that bug.