589259 - top outside corners of navigation toolbar need border radius

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Asa Dotzler [:asa]]

Attachment: screenshot comparing current trunk toolbar corner with mock-up

We need a border radius on the top right corner of the navigation toolbar.

Comment 1

[Asa Dotzler [:asa]]

We also need this for the left corner

Comment 2

[Peter Henkel [:Terepin]]

Already reported in bug 571662.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[pino_sb]

Attachment: showing a problem with this patch

This patch doesn't look right when tabs run to the edge of the window (if user hasn't placed buttons the tab toolbar). The tabs' outer edge no longer connects to the toolbar below. On the mockups the tab bar seems to have a little left and right margin to prevent this. 
A second thing is that this effect should be applied in tabs-on-bottom mode, with bookmarks toolbar enabled, too.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> This patch doesn't look right when tabs run to the edge of the window (if user
> hasn't placed buttons the tab toolbar).

That's not the only case where the tab bar would need padding. Doesn't need to be handled in this bug.

Comment 6

[imradyurrad]

(In reply to comment #5)
> That's not the only case where the tab bar would need padding. Doesn't need to
> be handled in this bug.

Should there just be a general bug for spacing/padding issues? More than one area of the navigation bar needs attention

Comment 7

[Valerio]

In tabs-on-bottom mode, this add border radius to the bookmarks toolbar: 

#main-window[sizemode="normal"] [tabsontop="false"] #PersonalToolbar {
  -moz-border-radius-topleft: 3px;
  -moz-border-radius-topright: 3px;
}

Comment 8

[Dão Gottwald [:dao]]

Attachment: more adjustments

Comment 9

[Asaf Romano (gone)]

Comment on attachment 477128 [details] [diff] [review]
more adjustments

r=mano

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/2a8b5ed8f29e

Comment 11

[Please Ignore This Troll (Account Disabled)]

You spend your time to fix such small and almost invisible things, like square corners while the bug with tabbar bouncing caused by making all tabs on tabbar pinned is still present. I even suggested you a fix with css and the bug is still there and even has an "unconfirmed" status.

Comment 12

[Please Ignore This Troll (Account Disabled)]

I hope that when the upcoming beltzner's retirement on pension (which will happen in 1 month) will bring you a new leader - he'll jack your @$$es good.

Comment 13

[Josh Tumath]

(In reply to comment #11)
> You spend your time to fix such small and almost invisible things, like square
> corners while the bug with tabbar bouncing caused by making all tabs on tabbar
> pinned is still present. I even suggested you a fix with css and the bug is
> still there and even has an "unconfirmed" status.

Bug comments are for discussing how the bug can be fixed; not being rude to developers and telling them what they should and should not do.

https://bugzilla.mozilla.org/page.cgi?id=etiquette.html

(I apologise for spamming everyone's bugmail with this comment.)

Comment 14

[Peter Henkel [:Terepin]]

(In reply to comment #11)
(In reply to comment #12)

Dude, you are so not cool.

On topic, Dao, I know there is separate bug for it, but while you were at it, why yiou didn't extend the border to entire window?

Comment 15

[Josh Tumath]

(In reply to comment #14)
> On topic, Dao, I know there is separate bug for it, but while you were at it,
> why yiou didn't extend the border to entire window?

Because there are plans to use the native glass border instead. See bug 588764.

Comment 16

[Peter Henkel [:Terepin]]

Then what was the point of removing them in the first place?

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: tabsonbottom

Doesn't tabs on bottom need something like this too?

Comment 18

[Dão Gottwald [:dao]]

Comment on attachment 484620 [details] [diff] [review]
tabsonbottom

Please file a new bug on this.