Closed
Bug 571685
Opened 14 years ago
Closed 14 years ago
Move remainders of webshell into /docshell/base
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file, 1 obsolete file)
10.94 KB,
patch
|
Details | Diff | Splinter Review |
See bug 490957 comment 1. I got a little carried away by whitespace cleanup; I hope you don't mind.
Attachment #450858 -
Flags: review?(benjamin)
Comment 1•14 years ago
|
||
Comment on attachment 450858 [details] [diff] [review]
Patch v1
ok with me, but bz should really confirm
Attachment #450858 -
Flags: review?(benjamin) → review?(bzbarsky)
Comment 2•14 years ago
|
||
Comment on attachment 450858 [details] [diff] [review]
Patch v1
Sure thing.
Attachment #450858 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 450858 [details] [diff] [review]
Patch v1
Thanks!
Attachment #450858 -
Flags: approval2.0?
Comment 4•14 years ago
|
||
Comment on attachment 450858 [details] [diff] [review]
Patch v1
I don't think we want to take this until after branch.
Attachment #450858 -
Flags: approval2.0? → approval2.0-
Assignee | ||
Updated•14 years ago
|
Whiteboard: [needs landing]
Comment on attachment 450858 [details] [diff] [review]
Patch v1
>diff --git a/browser/installer/removed-files.in b/browser/installer/removed-files.in
>--- a/browser/installer/removed-files.in
>+++ b/browser/installer/removed-files.in
>@@ -52,16 +52,17 @@ components/nsCloseAllWindows.js
> components/nsCloseAllWindows.js
> components/nsDictionary.js
> components/nsExtensionManager.js
> components/nsInterfaceInfoToIDL.js
> components/nsScriptableIO.js
> components/nsUrlClassifierTable.js
> components/nsXmlRpcClient.js
> components/sidebar.xpt
>+components/webshell_idls.xpt
> components/xmlextras.xpt
> components/xpcom.xpt
> components/xpti.dat
> components/xptitemp.dat
> defaults/pref/all.js
> defaults/pref/bug259708.js
> defaults/pref/bug307259.js
> defaults/pref/security-prefs.js
Adding this to removed-files.in is unnecessary, we don't actually ship this file.
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing]
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #450858 -
Attachment is obsolete: true
Comment 7•14 years ago
|
||
Flags: in-testsuite-
Whiteboard: fixed-in-cedar
Updated•14 years ago
|
Keywords: checkin-needed
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
No longer depends on: post2.0
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•