Closed Bug 571978 Opened 14 years ago Closed 14 years ago

Add command line option to specify a custom repository url for test-runs

Categories

(Mozilla QA Graveyard :: Mozmill Automation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now we always fetch the repository from hg.mozilla.org. We should add another command line option which will allow the user to also specify another location, i.e. on the local disk. This is useful to start the test-run against tests which are in the works and haven't been checked in yet.
Component: Mozmill → Mozmill Tests
QA Contact: mozmill → mozmilltests
Attached patch Patch v1 (obsolete) — Splinter Review
This patch adds the new --repository command line option, which can be used to work with a local repository. Andrew, any feedback for refactoring we should add to bug 566761. This patch will help us a lot during local test development and is necessary for the crowd extension.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #465386 - Flags: review?(ahalberstadt)
Attached patch Patch v1.1Splinter Review
Removed unnecessary constructor for the GeneralTestRun.
Attachment #465386 - Attachment is obsolete: true
Attachment #465400 - Flags: review?(ahalberstadt)
Attachment #465386 - Flags: review?(ahalberstadt)
Comment on attachment 465400 [details] [diff] [review]
Patch v1.1

>+    addons = AddonsTestRun(binaries=args,
>+                           addons=options.addons,
>+                           logfile=options.logfile,
>+                           report_url=options.report,
>                            with_untrusted=options.with_untrusted)
>+
>+    if options.repository_url:
>+      addons.repository_url = options.repository_url
>+
>     addons.run()

I know that you said to address refactoring comments to the other bug, but seeing as we already pass all the other properties for this one specific class into __init__, why not set the 'repository_url' property the same way at least for this case?

Looks good otherwise.
r=ahalberstadt
Attachment #465400 - Flags: review?(ahalberstadt) → review+
(In reply to comment #3)
> I know that you said to address refactoring comments to the other bug, but
> seeing as we already pass all the other properties for this one specific class
> into __init__, why not set the 'repository_url' property the same way at least
> for this case?

Makes sense. I have updated that part before the check-in:
http://hg.mozilla.org/qa/mozmill-automation/rev/c19cc0f1d54a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Move of Mozmill related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill Tests → Mozmill Automation
Product: Testing → Mozilla QA
QA Contact: mozmill-tests → mozmill-automation
Whiteboard: [mozmill-automation]
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: