604644 - Default repository_url broken for non-Firefox apps.

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Bug 571978 broke the setting of the default repository_url for non-Firefox apps.

In TestRun's __init__ function, we have:

http://hg.mozilla.org/qa/mozmill-automation/file/c19cc0f1d54a/libs/testrun.py#l70

def __init__(self):
    self.application = "firefox"
...
    self.repository_url = MOZMILL_TESTS_REPOSITORIES[self.application]

This means that the url is always going to be set for Firefox.

The current set-up of the code is that __init__ will get called, and then the individual members are set. I think we should just change this so that each class declares which variables it can take, and have them passed at initialisation. Then we can choose a sensible default or what has been passed in as appropriate.

I'm attaching a patch for this. I've only run the update tests, but I think it should all work.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Good catch Mark, and I'm sorry that I missed that. Your work here already fixes a part of the work I have planned on bug 566761. Lets see what's left over there. Thanks for the patch.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 483459 [details] [diff] [review]
The fix

Looks good and seems to include all the work from the other bug! Awesome.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/175518fc3185

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.