Default repository_url broken for non-Firefox apps.

RESOLVED FIXED

Status

Mozilla QA Graveyard
Mozmill Automation
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 483459 [details] [diff] [review]
The fix

Bug 571978 broke the setting of the default repository_url for non-Firefox apps.

In TestRun's __init__ function, we have:

http://hg.mozilla.org/qa/mozmill-automation/file/c19cc0f1d54a/libs/testrun.py#l70

def __init__(self):
    self.application = "firefox"
...
    self.repository_url = MOZMILL_TESTS_REPOSITORIES[self.application]

This means that the url is always going to be set for Firefox.

The current set-up of the code is that __init__ will get called, and then the individual members are set. I think we should just change this so that each class declares which variables it can take, and have them passed at initialisation. Then we can choose a sensible default or what has been passed in as appropriate.

I'm attaching a patch for this. I've only run the update tests, but I think it should all work.
Attachment #483459 - Flags: review?(hskupin)
(Assignee)

Updated

7 years ago
Blocks: 580237
Good catch Mark, and I'm sorry that I missed that. Your work here already fixes a part of the work I have planned on bug 566761. Lets see what's left over there. Thanks for the patch.
Blocks: 562639, 566761
Status: NEW → ASSIGNED
Keywords: regression
Whiteboard: [mozmill-automation]
Comment on attachment 483459 [details] [diff] [review]
The fix

Looks good and seems to include all the work from the other bug! Awesome.
Attachment #483459 - Flags: review?(hskupin) → review+
Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/175518fc3185
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Move of Mozmill related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill Tests → Mozmill Automation
Product: Testing → Mozilla QA
QA Contact: mozmill-tests → mozmill-automation
Whiteboard: [mozmill-automation]
Version: Trunk → unspecified
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.