Closed Bug 572049 Opened 10 years ago Closed 10 years ago

Make notification bar open the Addon Manager in browser rather than its own window

Categories

(SeaMonkey :: UI Design, defect)

x86
Windows XP
defect
Not set

Tracking

(blocking-seamonkey2.1 a2+)

RESOLVED FIXED
seamonkey2.1a2
Tracking Status
blocking-seamonkey2.1 --- a2+

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file, 1 obsolete file)

This should enable the notification bar to open a new tab/window depending on prefs instead of loading the Addon Manager like we used to.
Attached patch Just do it (obsolete) — Splinter Review
Attachment #451210 - Flags: review?(neil)
Comment on attachment 451210 [details] [diff] [review]
Just do it

>+            var whereToOpen = self._prefs.getIntPref("browser.link.open_external");
Unfortunately this is an event listener, so "this" refers to the disabled plugin, but there's no "self" either.
Attached patch v2Splinter Review
This does it, but does not abstract out the common bits; I'm just hoping to get this in for a2 faster, and do the abstraction shortly after in a followup.
Attachment #451210 - Attachment is obsolete: true
Attachment #452651 - Flags: review?(neil)
Attachment #451210 - Flags: review?(neil)
Comment on attachment 452651 [details] [diff] [review]
v2

For a second I wondered what common bits you were referring to but I worked it out.
Attachment #452651 - Flags: review?(neil) → review+
blocking-seamonkey2.1: ? → a2+
http://hg.mozilla.org/comm-central/rev/157a048e1117
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a2
So, when will browser.chromeURL not be navigator.xul in suite.

+              var browserURL = "chrome://navigator/content/navigator.xul";
+              try {
+                browserURL = self._prefs.getCharPref("browser.chromeURL");
+              } catch (ex) {}
Depends on: 573921
You need to log in before you can comment on or make changes to this bug.