Last Comment Bug 572049 - Make notification bar open the Addon Manager in browser rather than its own window
: Make notification bar open the Addon Manager in browser rather than its own w...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: x86 Windows XP
: -- normal (vote)
: seamonkey2.1a2
Assigned To: Justin Wood (:Callek)
:
:
Mentors:
Depends on: 573921
Blocks: SMAddonMgr
  Show dependency treegraph
 
Reported: 2010-06-14 20:37 PDT by Justin Wood (:Callek)
Modified: 2010-06-23 01:23 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
a2+


Attachments
Just do it (2.42 KB, patch)
2010-06-14 20:37 PDT, Justin Wood (:Callek)
no flags Details | Diff | Splinter Review
v2 (3.27 KB, patch)
2010-06-20 23:27 PDT, Justin Wood (:Callek)
neil: review+
Details | Diff | Splinter Review

Description Justin Wood (:Callek) 2010-06-14 20:37:23 PDT
This should enable the notification bar to open a new tab/window depending on prefs instead of loading the Addon Manager like we used to.
Comment 1 Justin Wood (:Callek) 2010-06-14 20:37:50 PDT
Created attachment 451210 [details] [diff] [review]
Just do it
Comment 2 neil@parkwaycc.co.uk 2010-06-15 01:31:35 PDT
Comment on attachment 451210 [details] [diff] [review]
Just do it

>+            var whereToOpen = self._prefs.getIntPref("browser.link.open_external");
Unfortunately this is an event listener, so "this" refers to the disabled plugin, but there's no "self" either.
Comment 3 Justin Wood (:Callek) 2010-06-20 23:27:33 PDT
Created attachment 452651 [details] [diff] [review]
v2

This does it, but does not abstract out the common bits; I'm just hoping to get this in for a2 faster, and do the abstraction shortly after in a followup.
Comment 4 neil@parkwaycc.co.uk 2010-06-21 03:15:14 PDT
Comment on attachment 452651 [details] [diff] [review]
v2

For a second I wondered what common bits you were referring to but I worked it out.
Comment 5 Justin Wood (:Callek) 2010-06-21 22:32:51 PDT
http://hg.mozilla.org/comm-central/rev/157a048e1117
Comment 6 Philip Chee 2010-06-22 21:24:48 PDT
So, when will browser.chromeURL not be navigator.xul in suite.

+              var browserURL = "chrome://navigator/content/navigator.xul";
+              try {
+                browserURL = self._prefs.getCharPref("browser.chromeURL");
+              } catch (ex) {}

Note You need to log in before you can comment on or make changes to this bug.