Make notification bar open the Addon Manager in browser rather than its own window

RESOLVED FIXED in seamonkey2.1a2

Status

SeaMonkey
UI Design
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Trunk
seamonkey2.1a2
x86
Windows XP
Dependency tree / graph

Firefox Tracking Flags

(blocking-seamonkey2.1 a2+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

v2
3.27 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
This should enable the notification bar to open a new tab/window depending on prefs instead of loading the Addon Manager like we used to.
(Assignee)

Comment 1

7 years ago
Created attachment 451210 [details] [diff] [review]
Just do it
Attachment #451210 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 451210 [details] [diff] [review]
Just do it

>+            var whereToOpen = self._prefs.getIntPref("browser.link.open_external");
Unfortunately this is an event listener, so "this" refers to the disabled plugin, but there's no "self" either.
(Assignee)

Comment 3

7 years ago
Created attachment 452651 [details] [diff] [review]
v2

This does it, but does not abstract out the common bits; I'm just hoping to get this in for a2 faster, and do the abstraction shortly after in a followup.
Attachment #451210 - Attachment is obsolete: true
Attachment #452651 - Flags: review?(neil)
Attachment #451210 - Flags: review?(neil)

Comment 4

7 years ago
Comment on attachment 452651 [details] [diff] [review]
v2

For a second I wondered what common bits you were referring to but I worked it out.
Attachment #452651 - Flags: review?(neil) → review+

Updated

7 years ago
blocking-seamonkey2.1: ? → a2+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/comm-central/rev/157a048e1117
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Target Milestone: --- → seamonkey2.1a2

Comment 6

7 years ago
So, when will browser.chromeURL not be navigator.xul in suite.

+              var browserURL = "chrome://navigator/content/navigator.xul";
+              try {
+                browserURL = self._prefs.getCharPref("browser.chromeURL");
+              } catch (ex) {}
(Assignee)

Updated

7 years ago
Depends on: 573921
You need to log in before you can comment on or make changes to this bug.