572049 - Make notification bar open the Addon Manager in browser rather than its own window

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Justin Wood (:Callek)]

This should enable the notification bar to open a new tab/window depending on prefs instead of loading the Addon Manager like we used to.

Comment 1

[Justin Wood (:Callek)]

Attachment: Just do it

Comment 2

[[e-mail]]

Comment on attachment 451210 [details] [diff] [review]
Just do it

>+            var whereToOpen = self._prefs.getIntPref("browser.link.open_external");
Unfortunately this is an event listener, so "this" refers to the disabled plugin, but there's no "self" either.

Comment 3

[Justin Wood (:Callek)]

Attachment: v2

This does it, but does not abstract out the common bits; I'm just hoping to get this in for a2 faster, and do the abstraction shortly after in a followup.

Comment 4

[[e-mail]]

Comment on attachment 452651 [details] [diff] [review]
v2

For a second I wondered what common bits you were referring to but I worked it out.

Comment 5

[Justin Wood (:Callek)]

http://hg.mozilla.org/comm-central/rev/157a048e1117

Comment 6

[Philip Chee]

So, when will browser.chromeURL not be navigator.xul in suite.

+              var browserURL = "chrome://navigator/content/navigator.xul";
+              try {
+                browserURL = self._prefs.getCharPref("browser.chromeURL");
+              } catch (ex) {}