Update browser_pluginnotification.js to work with Addon Manager in tab.

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
Testing Infrastructure
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Callek, Assigned: Robert Kaiser)

Tracking

(Blocks: 1 bug, {intermittent-failure, regression})

Trunk
seamonkey2.1a3
x86
Windows XP
intermittent-failure, regression
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [sm-perma][cc-orange])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
First failure is from Bug 572049, second failure is a todo on our end (I'll mark it as such in test). but will be done for a3

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_pluginnotification.js | Should have opened the correct window - Got chrome://navigator/content/navigator.xul, expected chrome://mozapps/content/extensions/extensions.xul
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/suite/browser/test/browser_pluginnotification.js | Should have displayed the plugins pane - Got undefined, expected plugins
(Reporter)

Comment 1

7 years ago
err sorry for bugspam...

*/suite/browser/... its not this bug.
(Reporter)

Comment 2

7 years ago
(In reply to comment #1)
> err sorry for bugspam...
> 
> */suite/browser/... its not this bug.

Ok (too tired;) wrong bug to comment on
(Assignee)

Comment 3

7 years ago
Created attachment 459438 [details] [diff] [review]
fix this bug by porting the Firefox changes and force open in tab

This patch fixes the bug at least locally for me. We need to set the pref to force opening in a tab (I think we actually should make that the default, but that's for a different bug).

I known Ian has been looking into the same (my fault for not attaching this patch earlier), so requesting review from him.
Assignee: bugspam.Callek → kairo
Status: NEW → ASSIGNED
Attachment #459438 - Flags: review?(iann_bugzilla)

Comment 4

7 years ago
Comment on attachment 459438 [details] [diff] [review]
fix this bug by porting the Firefox changes and force open in tab

>@@ -18,88 +19,79 @@ function get_test_plugin() {
>   
Nit: remove white space on the line above :)
>   // Find the test plugin
>   for (var i = 0; i < tags.length; i++) {
>     if (tags[i].name == "Test Plug-in")
>       return tags[i];
>   }
> }
>+  //Services.prefs.setIntPref("browser.link.open_newwindow", 3);
Do we need to leave this line in?

>+  //Services.prefs.clearUserPref("browser.link.open_newwindow");
Ditto

r=me with those addressed.
Attachment #459438 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 5

7 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/4ae37dbcfb16

I did put a comment in about the prefs setting/clearing being obsoleted by bug 505311 some time when it gets reviews.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
Keywords: intermittent-failure
Whiteboard: [sm-perma][orange] → [sm-perma]

Updated

5 years ago
Whiteboard: [sm-perma] → [sm-perma][cc-orange]
You need to log in before you can comment on or make changes to this bug.